Skip to content

Commit 9883918

Browse files
committed
Make suggested build changes
1 parent 3d62679 commit 9883918

3 files changed

Lines changed: 5 additions & 18 deletions

File tree

network/common/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,6 @@
8585
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
8686
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
8787
<plugins>
88-
<plugin>
89-
<groupId>org.scalatest</groupId>
90-
<artifactId>scalatest-maven-plugin</artifactId>
91-
</plugin>
9288
<!-- Create a test-jar so network-shuffle can depend on our test utilities. -->
9389
<plugin>
9490
<groupId>org.apache.maven.plugins</groupId>

network/common/src/main/java/org/apache/spark/network/client/TransportClient.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import java.util.concurrent.TimeoutException;
2525

2626
import com.google.common.base.Preconditions;
27+
import com.google.common.base.Throwables;
2728
import com.google.common.util.concurrent.SettableFuture;
2829
import io.netty.channel.Channel;
2930
import io.netty.channel.ChannelFuture;
@@ -175,12 +176,8 @@ public void onFailure(Throwable e) {
175176

176177
try {
177178
return result.get(timeoutMs, TimeUnit.MILLISECONDS);
178-
} catch (InterruptedException e) {
179-
throw new RuntimeException(e);
180-
} catch (ExecutionException e) {
181-
throw new RuntimeException(e);
182-
} catch (TimeoutException e) {
183-
throw new RuntimeException(e);
179+
} catch (Exception e) {
180+
throw Throwables.propagate(e);
184181
}
185182
}
186183

network/shuffle/pom.xml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<dependency>
4141
<groupId>org.apache.spark</groupId>
4242
<artifactId>spark-network-common_2.10</artifactId>
43-
<version>1.2.0-SNAPSHOT</version>
43+
<version>${project.version}</version>
4444
</dependency>
4545
<dependency>
4646
<groupId>org.slf4j</groupId>
@@ -58,7 +58,7 @@
5858
<dependency>
5959
<groupId>org.apache.spark</groupId>
6060
<artifactId>spark-network-common_2.10</artifactId>
61-
<version>1.2.0-SNAPSHOT</version>
61+
<version>${project.version}</version>
6262
<type>test-jar</type>
6363
<scope>test</scope>
6464
</dependency>
@@ -92,11 +92,5 @@
9292
<build>
9393
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
9494
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
95-
<plugins>
96-
<plugin>
97-
<groupId>org.scalatest</groupId>
98-
<artifactId>scalatest-maven-plugin</artifactId>
99-
</plugin>
100-
</plugins>
10195
</build>
10296
</project>

0 commit comments

Comments
 (0)