Skip to content

Commit 810948d

Browse files
committed
further fix
1 parent a40e8fb commit 810948d

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

core/src/main/scala/org/apache/spark/rdd/RDD.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,8 +310,7 @@ abstract class RDD[T: ClassTag](
310310
* Return a sampled subset of this RDD.
311311
*/
312312
def sample(withReplacement: Boolean, fraction: Double, seed: Int): RDD[T] = {
313-
require(fraction >= 0 && fraction <= Double.MaxValue,
314-
"Invalid fraction value: " + fraction)
313+
require(fraction >= 0.0, "Invalid fraction value: " + fraction)
315314
if (withReplacement) {
316315
new PartitionwiseSampledRDD[T, T](this, new PoissonSampler[T](fraction), seed)
317316
} else {

core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -457,10 +457,10 @@ class RDDSuite extends FunSuite with SharedSparkContext {
457457

458458
test("takeSample") {
459459
val data = sc.parallelize(1 to 100, 2)
460-
val emptySet = data.filter(_ => false)
460+
val emptySet = data.mapPartitions { iter => Iterator.empty }
461461

462462
val sample = emptySet.takeSample(false, 20, 1)
463-
assert(sample.size === 0)
463+
assert(sample.length === 0)
464464
for (seed <- 1 to 5) {
465465
val sample = data.takeSample(withReplacement=false, 20, seed)
466466
assert(sample.size === 20) // Got exactly 20 elements

0 commit comments

Comments
 (0)