Skip to content

Commit 61f850d

Browse files
committed
use same notation in comments
1 parent 795ede6 commit 61f850d

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1907,7 +1907,7 @@ class TaskSetManagerSuite
19071907
task.metrics.internalAccums
19081908
}
19091909

1910-
// Start TASK 0,1 on exec1, Task 2 on exec2
1910+
// Start TASK 0,1 on exec1, TASK 2 on exec2
19111911
(0 until 2).foreach { _ =>
19121912
val taskOption = manager.resourceOffer("exec1", "host1", NO_PREF)._1
19131913
assert(taskOption.isDefined)
@@ -1939,16 +1939,16 @@ class TaskSetManagerSuite
19391939
assert(sched.speculativeTasks.toSet === Set())
19401940

19411941
// decommission exec-2. All tasks running on exec-2 (i.e. TASK 2,3) will be added to
1942-
// executorDecommissionSpeculationTriggerTimeoutOpt
1943-
// (TASK2 -> 15, TASK3 -> 15)
1942+
// executorDecommissionSpeculationTriggerTimeoutOpt
1943+
// (TASK 2 -> 15, TASK 3 -> 15)
19441944
manager.executorDecommission("exec2")
19451945
assert(manager.tidToExecutorKillTimeMapping.keySet === Set(2, 3))
19461946
assert(manager.tidToExecutorKillTimeMapping(2) === 15*1000)
19471947
assert(manager.tidToExecutorKillTimeMapping(3) === 15*1000)
19481948

19491949
assert(manager.checkSpeculatableTasks(0))
1950-
// Task2 started at t=0s, so it can still finish before t=15s (Median task runtime = 10s)
1951-
// Task3 started at t=6s, so it might not finish before t=15s. So Task 3 should be part
1950+
// TASK 2 started at t=0s, so it can still finish before t=15s (Median task runtime = 10s)
1951+
// TASK 3 started at t=6s, so it might not finish before t=15s. So TASK 3 should be part
19521952
// of speculativeTasks
19531953
assert(sched.speculativeTasks.toSet === Set(3))
19541954
assert(manager.copiesRunning(3) === 1)
@@ -1973,8 +1973,8 @@ class TaskSetManagerSuite
19731973
assert(manager.copiesRunning(3) === 2)
19741974

19751975
clock.advance(5*1000) // time = 16s
1976-
// At t=16s, Task 2 has been running for 16s. It is more than the
1977-
// SPECULATION_MULTIPLIER * medianRuntime = 1.5 * 10 = 15s. So now Task 2 will
1976+
// At t=16s, TASK 2 has been running for 16s. It is more than the
1977+
// SPECULATION_MULTIPLIER * medianRuntime = 1.5 * 10 = 15s. So now TASK 2 will
19781978
// be selected for speculation. Here we are verifying that regular speculation configs
19791979
// should still take effect even when a EXECUTOR_DECOMMISSION_KILL_INTERVAL is provided and
19801980
// corresponding executor is decommissioned
@@ -1985,7 +1985,7 @@ class TaskSetManagerSuite
19851985
val taskOption2New = manager.resourceOffer("exec3", "host3", NO_PREF)._1
19861986
assert(taskOption2New.isDefined)
19871987
val speculativeTask2 = taskOption2New.get
1988-
// Ensure that task index 2 is launched on exec3, host3
1988+
// Ensure that TASK 2 is re-launched on exec3, host3
19891989
assert(speculativeTask2.index === 2)
19901990
assert(speculativeTask2.taskId === 5)
19911991
assert(speculativeTask2.executorId === "exec3")

0 commit comments

Comments
 (0)