Skip to content

Commit 5422f10

Browse files
committed
Fixed log statement and comment
1 parent 72b5976 commit 5422f10

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -885,7 +885,7 @@ void resetChunkTracker() {
885885
*/
886886
void updateChunkInfo(long chunkOffset, int mapIndex) throws IOException {
887887
try {
888-
logger.trace("{} shuffleId {} reduceId {} updated index current {} updated {}",
888+
logger.trace("{} shuffleId {} reduceId {} index current {} updated {}",
889889
appShuffleId.appId, appShuffleId.shuffleId, reduceId, this.lastChunkOffset, chunkOffset);
890890
if (indexMetaUpdateFailed) {
891891
indexFile.getChannel().position(indexFile.getPos());
@@ -894,7 +894,7 @@ void updateChunkInfo(long chunkOffset, int mapIndex) throws IOException {
894894
// Chunk bitmap should be written to the meta file after the index file because if there are
895895
// any exceptions during writing the offset to the index file, meta file should not be
896896
// updated. If the update to the index file is successful but the update to meta file isn't
897-
// then the index file position is reset in the catch clause.
897+
// then the index file position is not updated.
898898
writeChunkTracker(mapIndex);
899899
indexFile.updatePos(8);
900900
this.lastChunkOffset = chunkOffset;

common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,6 @@ public void testRecoverIndexFileAfterIOExceptions() throws IOException {
451451
@Test
452452
public void testRecoverIndexFileAfterIOExceptionsInFinalize() throws IOException {
453453
useTestFiles(true, false);
454-
registerExecutor(TEST_APP, prepareLocalDirs(localDirs));
455454
RemoteBlockPushResolver.PushBlockStreamCallback callback1 =
456455
(RemoteBlockPushResolver.PushBlockStreamCallback) pushResolver.receiveBlockDataAsStream(
457456
new PushBlockStream(TEST_APP, 0, 0, 0, 0));

0 commit comments

Comments
 (0)