Skip to content

Commit 515b38b

Browse files
committed
quotes around property name
1 parent 74a9905 commit 515b38b

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/TimestampTableTimeZoneSuite.scala

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -262,13 +262,14 @@ abstract class BaseTimestampTableTimeZoneSuite extends SparkPlanTest with SQLTes
262262
// Finally, try changing the tbl timezone. This destroys integrity
263263
// of the existing data, but at this point we're just checking we can change
264264
// the metadata
265-
spark.sql(s"""ALTER TABLE $tblName SET TBLPROPERTIES ($key="America/Los_Angeles")""")
265+
spark.sql(
266+
s"""ALTER TABLE $tblName SET TBLPROPERTIES ("$key"="America/Los_Angeles")""")
266267
checkHasTz(spark, tblName, Some("America/Los_Angeles"))
267268

268-
spark.sql(s"""ALTER TABLE $tblName UNSET TBLPROPERTIES ($key)""")
269+
spark.sql(s"""ALTER TABLE $tblName UNSET TBLPROPERTIES ("$key")""")
269270
checkHasTz(spark, tblName, None)
270271

271-
spark.sql(s"""ALTER TABLE $tblName SET TBLPROPERTIES ($key="UTC")""")
272+
spark.sql(s"""ALTER TABLE $tblName SET TBLPROPERTIES ("$key"="UTC")""")
272273
checkHasTz(spark, tblName, Some("UTC"))
273274
}
274275
}
@@ -307,7 +308,7 @@ abstract class BaseTimestampTableTimeZoneSuite extends SparkPlanTest with SQLTes
307308

308309
createAndSave.createAndSave(data.toDF(), "bad_tz_table", None, "parquet")
309310
hasBadTzException {
310-
spark.sql(s"""ALTER TABLE bad_tz_table SET TBLPROPERTIES($key="$badVal")""")
311+
spark.sql(s"""ALTER TABLE bad_tz_table SET TBLPROPERTIES("$key"="$badVal")""")
311312
}
312313
}
313314
}
@@ -336,14 +337,14 @@ abstract class BaseTimestampTableTimeZoneSuite extends SparkPlanTest with SQLTes
336337
withView("view_with_tz") {
337338
val exc1 = intercept[AnalysisException]{
338339
spark.sql(s"""CREATE VIEW view_with_tz
339-
| TBLPROPERTIES ($key="UTC")
340+
| TBLPROPERTIES ("$key"="UTC")
340341
| AS SELECT * FROM ok_table
341342
""".stripMargin)
342343
}
343344
assert(exc1.getMessage.contains("Timezone cannot be set for view"))
344345
spark.sql("CREATE VIEW view_with_tz AS SELECT * FROM ok_table")
345346
val exc2 = intercept[AnalysisException]{
346-
spark.sql(s"""ALTER VIEW view_with_tz SET TBLPROPERTIES($key="UTC")""")
347+
spark.sql(s"""ALTER VIEW view_with_tz SET TBLPROPERTIES("$key"="UTC")""")
347348
}
348349
assert(exc2.getMessage.contains("Timezone cannot be set for view"))
349350
}

sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveTimestampTableTimeZoneSuite.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class HiveTimestampTableTimeZoneSuite extends BaseTimestampTableTimeZoneSuite
3939
format: String): Boolean = {
4040
if (format == "parquet") {
4141
val tblProperties = tzOpt.map { tz =>
42-
s"""TBLPROPERTIES (${TimestampTableTimeZone.TIMEZONE_PROPERTY}="$tz")"""
42+
s"""TBLPROPERTIES ("${TimestampTableTimeZone.TIMEZONE_PROPERTY}"="$tz")"""
4343
}.getOrElse("")
4444
spark.sql(
4545
s"""CREATE TABLE $table (
@@ -65,7 +65,7 @@ class HiveTimestampTableTimeZoneSuite extends BaseTimestampTableTimeZoneSuite
6565
destFormat: String): Boolean = {
6666
if (destFormat == "parquet") {
6767
val tblProperties = destTz.map { tz =>
68-
s"""TBLPROPERTIES (${TimestampTableTimeZone.TIMEZONE_PROPERTY}="$tz")"""
68+
s"""TBLPROPERTIES ("${TimestampTableTimeZone.TIMEZONE_PROPERTY}"="$tz")"""
6969
}.getOrElse("")
7070
// this isn't just a "ctas" sql statement b/c that doesn't let us specify the table tz
7171
spark.sql(

0 commit comments

Comments
 (0)