[SPARK-12088][SQL]check connection.isClosed before calling connection.getAutoCommit in JDBCRDD

Huaxin Gao · Huaxin Gao · commit 0efeb958ed11 · 2015-12-01T12:41:06.000-08:00
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
@@ -498,7 +498,7 @@ private[sql] class JDBCRDD(
       }
       try {
         if (null != conn) {
-          if (!conn.getAutoCommit && !conn.isClosed) {
+          if (!conn.isClosed && !conn.getAutoCommit) {
             try {
               conn.commit()
             } catch {

Original file line number	Diff line number	Diff line change
`@@ -498,7 +498,7 @@ private[sql] class JDBCRDD(`
`498`	`498`	`}`
`499`	`499`	`try {`
`500`	`500`	`if (null != conn) {`
`501`		`- if (!conn.getAutoCommit && !conn.isClosed) {`
	`501`	`+ if (!conn.isClosed && !conn.getAutoCommit) {`
`502`	`502`	`try {`
`503`	`503`	`conn.commit()`
`504`	`504`	`} catch {`