Skip to content

Commit 0093376

Browse files
committed
Comment / indenting cleanup.
1 parent d81f998 commit 0093376

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,10 @@ abstract class CodeGenerator extends Logging {
6969
* @param objectTerm An possibly boxed version of the result of evaluating this expression.
7070
*/
7171
protected case class EvaluatedExpression(
72-
code: Seq[Tree],
73-
nullTerm: TermName,
74-
primitiveTerm: TermName,
75-
objectTerm: TermName) {
76-
77-
def withObjectTerm = ???
78-
}
72+
code: Seq[Tree],
73+
nullTerm: TermName,
74+
primitiveTerm: TermName,
75+
objectTerm: TermName)
7976

8077
/**
8178
* Given an expression tree returns the code required to determine both if the result is NULL

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ package object expressions {
5454
abstract class MutableProjection extends Projection {
5555
def currentValue: Row
5656

57-
/* Updates the target of this projection to a new MutableRow */
57+
/** Updates the target of this projection to a new MutableRow */
5858
def target(row: MutableRow): MutableProjection
5959
}
6060
}

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]] extends Logging {
7272
}
7373
iteration += 1
7474
if (iteration > batch.strategy.maxIterations) {
75+
// Only log if this is a rule that is supposed to run more than once.
7576
if (iteration != 2) {
7677
logger.info(s"Max iterations (${iteration - 1}) reached for batch ${batch.name}")
7778
}

0 commit comments

Comments
 (0)