Skip to content

Conversation

@jbampton
Copy link
Member

Another check or test we can have that lints workflow files.

Tested with pre-commit run --all-files currently passing

Static checker for GitHub Actions workflow files:

https://github.com/rhysd/actionlint

https://github.com/rhysd/actionlint/blob/v1.7.8/docs/usage.md#pre-commit

Try the online version:

https://rhysd.github.io/actionlint/

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@fpapon fpapon self-requested a review October 26, 2025 16:20
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbampton there is some conflict with main, can you rebase please?

Another check or test we can have that lints workflow files.

Tested with `pre-commit run --all-files` currently passing

Static checker for GitHub Actions workflow files:

https://github.com/rhysd/actionlint

https://github.com/rhysd/actionlint/blob/v1.7.8/docs/usage.md#pre-commit

Try the online version:

https://rhysd.github.io/actionlint/
@fpapon fpapon merged commit 7c87506 into apache:main Oct 29, 2025
31 of 32 checks passed
@jbampton jbampton deleted the add-actionlint branch October 30, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants