Merge pull request #2339 from jbampton/pre-commit-add-shellcheck

pre-commit: add `shellcheck` and clean shell files

Author: fpapon

.pre-commit-config.yaml

@@ -83,3 +83,9 @@ repos:
         name: run oxipng
         description: check PNG files with oxipng
         args: ['--fix', '-o', '4', '--strip', 'safe', '--alpha']
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.11.0.1
+    hooks:
+      - id: shellcheck
+        name: run shellcheck
+        description: check Shell scripts with shellcheck

integration-tests/support/src/main/resources/createKeyStore.sh

@@ -30,9 +30,10 @@ set -e
 # programmatically: `System.setProperty("javax.net.ssl.trustStore", "/path/to/keystore")`
 
 dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
+# shellcheck disable=SC2034
 keystore_file="${dir}/test-keystore.jks"
 file_prefix="${dir}/test-keystore"
-rm -f ${file_prefix}*
+rm -f "${file_prefix}"*
 
 echo "generate new keystore"
 keytool -genkey \