Fix bytea text encoding in PostgreSQL data rows (#37772)

Author: jonasHanhan

database/protocol/dialect/postgresql/src/main/java/org/apache/shardingsphere/database/protocol/postgresql/packet/command/query/PostgreSQLDataRowPacket.java

@@ -27,6 +27,7 @@
 import org.apache.shardingsphere.database.protocol.postgresql.packet.identifier.PostgreSQLMessagePacketType;
 import org.apache.shardingsphere.database.protocol.postgresql.payload.PostgreSQLPacketPayload;
 
+import java.nio.charset.StandardCharsets;
 import java.sql.SQLException;
 import java.sql.SQLXML;
 import java.util.Collection;
@@ -38,6 +39,8 @@
 @Getter
 public final class PostgreSQLDataRowPacket extends PostgreSQLIdentifierPacket {
 
+    private static final byte[] HEX_DIGITS = "0123456789abcdef".getBytes(StandardCharsets.US_ASCII);
+    
     private final Collection<Object> data;
 
     @Override
@@ -67,8 +70,9 @@ private void writeTextValue(final PostgreSQLPacketPayload payload, final Object
         if (null == each) {
             payload.writeInt4(0xFFFFFFFF);
         } else if (each instanceof byte[]) {
-            payload.writeInt4(((byte[]) each).length);
-            payload.writeBytes((byte[]) each);
+            byte[] columnData = encodeByteaText((byte[]) each);
+            payload.writeInt4(columnData.length);
+            payload.writeBytes(columnData);
         } else if (each instanceof SQLXML) {
             writeSQLXMLData(payload, each);
         } else if (each instanceof Boolean) {
@@ -82,6 +86,18 @@ private void writeTextValue(final PostgreSQLPacketPayload payload, final Object
         }
     }
 
+    private byte[] encodeByteaText(final byte[] value) {
+        byte[] result = new byte[value.length * 2 + 2];
+        result[0] = '\\';
+        result[1] = 'x';
+        for (int i = 0; i < value.length; i++) {
+            int unsignedByte = value[i] & 0xFF;
+            result[2 + i * 2] = HEX_DIGITS[unsignedByte >>> 4];
+            result[3 + i * 2] = HEX_DIGITS[unsignedByte & 0x0F];
+        }
+        return result;
+    }
+    
     private void writeSQLXMLData(final PostgreSQLPacketPayload payload, final Object data) {
         try {
             byte[] dataBytes = ((SQLXML) data).getString().getBytes(payload.getCharset());

database/protocol/dialect/postgresql/src/test/java/org/apache/shardingsphere/database/protocol/postgresql/packet/command/query/PostgreSQLDataRowPacketTest.java

@@ -68,8 +68,9 @@ void assertWriteWithNull() {
     void assertWriteWithBytes() {
         PostgreSQLDataRowPacket actual = new PostgreSQLDataRowPacket(Collections.singleton(new byte[]{'a'}));
         actual.write(payload);
-        verify(payload).writeInt4(new byte[]{'a'}.length);
-        verify(payload).writeBytes(new byte[]{'a'});
+        byte[] expectedBytes = buildExpectedByteaText(new byte[]{'a'});
+        verify(payload).writeInt4(expectedBytes.length);
+        verify(payload).writeBytes(expectedBytes);
     }
 
     @Test
@@ -122,4 +123,17 @@ void assertWriteBinaryInt4() {
     void assertGetIdentifier() {
         assertThat(new PostgreSQLDataRowPacket(Collections.emptyList()).getIdentifier(), is(PostgreSQLMessagePacketType.DATA_ROW));
     }
+    
+    private byte[] buildExpectedByteaText(final byte[] value) {
+        byte[] result = new byte[value.length * 2 + 2];
+        result[0] = '\\';
+        result[1] = 'x';
+        byte[] hexDigits = "0123456789abcdef".getBytes(StandardCharsets.US_ASCII);
+        for (int i = 0; i < value.length; i++) {
+            int unsignedByte = value[i] & 0xFF;
+            result[2 + i * 2] = hexDigits[unsignedByte >>> 4];
+            result[3 + i * 2] = hexDigits[unsignedByte & 0x0F];
+        }
+        return result;
+    }
 }