Skip to content

[MNG-7194] Test missing property evaluation #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[MNG-7194] Test missing property evaluation #1573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions maven-core/src/test/java/org/apache/maven/plugin/PluginParameterExpressionEvaluatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@
import org.codehaus.plexus.configuration.DefaultPlexusConfiguration;
import org.codehaus.plexus.util.Os;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;

import static org.codehaus.plexus.testing.PlexusExtension.getTestFile;
import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down Expand Up @@ -291,6 +293,34 @@ void testValueExtractionFromSystemPropertiesWithMissingProject() throws Exceptio
assertEquals("value", value);
}

@ParameterizedTest
@ValueSource(
strings = {
"prefix-${PPEET_nonexisting_ps_property}",
"${PPEET_nonexisting_ps_property}-suffix",
"prefix-${PPEET_nonexisting_ps_property}-suffix",
})
void testValueExtractionOfMissingPrefixedSuffixedProperty(String missingPropertyExpression) throws Exception {
Properties executionProperties = new Properties();

ExpressionEvaluator ee = createExpressionEvaluator(null, null, executionProperties);

Object value = ee.evaluate(missingPropertyExpression);

assertEquals(missingPropertyExpression, value);
}

@Test
void testValueExtractionOfMissingProperty() throws Exception {
Properties executionProperties = new Properties();

ExpressionEvaluator ee = createExpressionEvaluator(null, null, executionProperties);

Object value = ee.evaluate("${PPEET_nonexisting_property}");

assertNull(value);
}

@Test
void testValueExtractionFromSystemPropertiesWithMissingProject_WithDotNotation() throws Exception {
String sysprop = "PPEET.sysprop2";
Expand Down