Disable checkstyle:FileLength

Author: gnodet

maven-api-impl/pom.xml

@@ -29,6 +29,11 @@ under the License.
   <name>Maven API Implementation</name>
   <description>Provides the implementation classes for the Maven API</description>
 
+  <properties>
+    <!-- in: DefaultModelValidator, DefaultModelBuilder -->
+    <checkstyle.violation.ignore>FileLength</checkstyle.violation.ignore>
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.apache.maven</groupId>

maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelValidator.java

@@ -20,7 +20,6 @@
 
 import java.io.File;
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.Deque;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -134,7 +133,6 @@ protected Activation.Builder transformActivation_ActiveByDefault(
         protected Activation.Builder transformActivation_File(
                 Supplier<? extends Activation.Builder> creator, Activation.Builder builder, Activation target) {
             stk.push(nextFrame("file", Activation::getFile));
-            Optional.ofNullable(target.getFile());
             try {
                 return super.transformActivation_File(creator, builder, target);
             } finally {
@@ -333,7 +331,7 @@ public void validateFileModel(Model m, ModelBuilderRequest request, ModelProblem
         if (request.getValidationLevel() == ModelBuilderRequest.VALIDATION_LEVEL_MINIMAL) {
             // profiles: they are essential for proper model building (may contribute profiles, dependencies...)
             HashSet<String> minProfileIds = new HashSet<>();
-            for (org.apache.maven.api.model.Profile profile : m.getProfiles()) {
+            for (Profile profile : m.getProfiles()) {
                 if (!minProfileIds.add(profile.getId())) {
                     addViolation(
                             problems,
@@ -409,7 +407,6 @@ public void validateFileModel(Model m, ModelBuilderRequest request, ModelProblem
                 }
             }
 
-
             Severity errOn30 = getSeverity(request, ModelBuilderRequest.VALIDATION_LEVEL_MAVEN_3_0);
 
             // The file pom may not contain the modelVersion yet, as it may be set later by the
@@ -693,10 +690,6 @@ public void validateEffectiveModel(Model m, ModelBuilderRequest request, ModelPr
 
         validateStringNotEmpty("packaging", problems, Severity.ERROR, Version.BASE, m.getPackaging(), m);
 
-        // TODO: if the model is a 4.1.0:
-        //   * modules should be empty, else issue a warning
-        //   * validate subprojects
-
         if (!m.getModules().isEmpty()) {
             if (!"pom".equals(m.getPackaging())) {
                 addViolation(
@@ -963,7 +956,7 @@ private void validate20RawDependencies(
 
     private void validate20RawDependenciesSelfReferencing(
             ModelProblemCollector problems,
-            org.apache.maven.api.model.Model m,
+            Model m,
             List<Dependency> dependencies,
             String prefix,
             ModelBuilderRequest request) {
@@ -994,7 +987,7 @@ private void validate20RawDependenciesSelfReferencing(
 
     private void validateEffectiveDependencies(
             ModelProblemCollector problems,
-            org.apache.maven.api.model.Model m,
+            Model m,
             List<Dependency> dependencies,
             boolean management,
             ModelBuilderRequest request) {
@@ -1057,7 +1050,7 @@ private void validateEffectiveDependencies(
     private void validateEffectiveModelAgainstDependency(
             String prefix,
             ModelProblemCollector problems,
-            org.apache.maven.api.model.Model m,
+            Model m,
             Dependency d,
             ModelBuilderRequest request) {
         String key = d.getGroupId() + ":" + d.getArtifactId() + ":" + d.getVersion()