Skip to content

Commit fefbe23

Browse files
committed
[MNG-8329] ArtifactInstallerRequest and ArtifactDeployerRequest should use Collection<ProducedArtifact>
1 parent 3425b4d commit fefbe23

File tree

2 files changed

+18
-16
lines changed

2 files changed

+18
-16
lines changed

api/maven-api-core/src/main/java/org/apache/maven/api/services/ArtifactDeployerRequest.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
import java.util.Collection;
2222

23-
import org.apache.maven.api.Artifact;
23+
import org.apache.maven.api.ProducedArtifact;
2424
import org.apache.maven.api.RemoteRepository;
2525
import org.apache.maven.api.Session;
2626
import org.apache.maven.api.annotations.Experimental;
@@ -45,7 +45,7 @@ public interface ArtifactDeployerRequest {
4545
RemoteRepository getRepository();
4646

4747
@Nonnull
48-
Collection<Artifact> getArtifacts();
48+
Collection<ProducedArtifact> getArtifacts();
4949

5050
int getRetryFailedDeploymentCount();
5151

@@ -56,7 +56,9 @@ static ArtifactDeployerRequestBuilder builder() {
5656

5757
@Nonnull
5858
static ArtifactDeployerRequest build(
59-
@Nonnull Session session, @Nonnull RemoteRepository repository, @Nonnull Collection<Artifact> artifacts) {
59+
@Nonnull Session session,
60+
@Nonnull RemoteRepository repository,
61+
@Nonnull Collection<ProducedArtifact> artifacts) {
6062
return builder()
6163
.session(nonNull(session, "session cannot be null"))
6264
.repository(nonNull(repository, "repository cannot be null"))
@@ -67,7 +69,7 @@ static ArtifactDeployerRequest build(
6769
class ArtifactDeployerRequestBuilder {
6870
Session session;
6971
RemoteRepository repository;
70-
Collection<Artifact> artifacts;
72+
Collection<ProducedArtifact> artifacts;
7173
int retryFailedDeploymentCount;
7274

7375
ArtifactDeployerRequestBuilder() {}
@@ -84,7 +86,7 @@ public ArtifactDeployerRequestBuilder repository(RemoteRepository repository) {
8486
return this;
8587
}
8688

87-
public ArtifactDeployerRequestBuilder artifacts(Collection<Artifact> artifacts) {
89+
public ArtifactDeployerRequestBuilder artifacts(Collection<ProducedArtifact> artifacts) {
8890
this.artifacts = artifacts;
8991
return this;
9092
}
@@ -102,13 +104,13 @@ public ArtifactDeployerRequest build() {
102104
private static class DefaultArtifactDeployerRequest extends BaseRequest implements ArtifactDeployerRequest {
103105

104106
private final RemoteRepository repository;
105-
private final Collection<Artifact> artifacts;
107+
private final Collection<? extends ProducedArtifact> artifacts;
106108
private final int retryFailedDeploymentCount;
107109

108110
DefaultArtifactDeployerRequest(
109111
@Nonnull Session session,
110112
@Nonnull RemoteRepository repository,
111-
@Nonnull Collection<Artifact> artifacts,
113+
@Nonnull Collection<? extends ProducedArtifact> artifacts,
112114
int retryFailedDeploymentCount) {
113115
super(session);
114116
this.repository = nonNull(repository, "repository cannot be null");
@@ -124,7 +126,7 @@ public RemoteRepository getRepository() {
124126

125127
@Nonnull
126128
@Override
127-
public Collection<Artifact> getArtifacts() {
129+
public Collection<? extends ProducedArtifact> getArtifacts() {
128130
return artifacts;
129131
}
130132

api/maven-api-core/src/main/java/org/apache/maven/api/services/ArtifactInstallerRequest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import java.util.Collection;
2222
import java.util.Collections;
2323

24-
import org.apache.maven.api.Artifact;
24+
import org.apache.maven.api.ProducedArtifact;
2525
import org.apache.maven.api.Session;
2626
import org.apache.maven.api.annotations.Experimental;
2727
import org.apache.maven.api.annotations.Immutable;
@@ -44,15 +44,15 @@ public interface ArtifactInstallerRequest {
4444
Session getSession();
4545

4646
@Nonnull
47-
Collection<Artifact> getArtifacts();
47+
Collection<ProducedArtifact> getArtifacts();
4848

4949
@Nonnull
5050
static ArtifactInstallerRequestBuilder builder() {
5151
return new ArtifactInstallerRequestBuilder();
5252
}
5353

5454
@Nonnull
55-
static ArtifactInstallerRequest build(Session session, Collection<Artifact> artifacts) {
55+
static ArtifactInstallerRequest build(Session session, Collection<ProducedArtifact> artifacts) {
5656
return builder()
5757
.session(nonNull(session, "session cannot be null"))
5858
.artifacts(nonNull(artifacts, "artifacts cannot be null"))
@@ -62,7 +62,7 @@ static ArtifactInstallerRequest build(Session session, Collection<Artifact> arti
6262
@NotThreadSafe
6363
class ArtifactInstallerRequestBuilder {
6464
Session session;
65-
Collection<Artifact> artifacts = Collections.emptyList();
65+
Collection<ProducedArtifact> artifacts = Collections.emptyList();
6666

6767
ArtifactInstallerRequestBuilder() {}
6868

@@ -73,7 +73,7 @@ public ArtifactInstallerRequestBuilder session(@Nonnull Session session) {
7373
}
7474

7575
@Nonnull
76-
public ArtifactInstallerRequestBuilder artifacts(@Nullable Collection<Artifact> artifacts) {
76+
public ArtifactInstallerRequestBuilder artifacts(@Nullable Collection<ProducedArtifact> artifacts) {
7777
this.artifacts = artifacts != null ? artifacts : Collections.emptyList();
7878
return this;
7979
}
@@ -85,16 +85,16 @@ public ArtifactInstallerRequest build() {
8585

8686
static class DefaultArtifactInstallerRequest extends BaseRequest implements ArtifactInstallerRequest {
8787

88-
private final Collection<Artifact> artifacts;
88+
private final Collection<ProducedArtifact> artifacts;
8989

90-
DefaultArtifactInstallerRequest(@Nonnull Session session, @Nonnull Collection<Artifact> artifacts) {
90+
DefaultArtifactInstallerRequest(@Nonnull Session session, @Nonnull Collection<ProducedArtifact> artifacts) {
9191
super(session);
9292
this.artifacts = unmodifiable(nonNull(artifacts, "artifacts cannot be null"));
9393
}
9494

9595
@Nonnull
9696
@Override
97-
public Collection<Artifact> getArtifacts() {
97+
public Collection<ProducedArtifact> getArtifacts() {
9898
return artifacts;
9999
}
100100
}

0 commit comments

Comments
 (0)