Thrown a more meaningful exception

gnodet · gnodet · commit ae56c9b76e66 · 2024-11-25T08:05:44.000+01:00
diff --git a/impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlan.java b/impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlan.java
@@ -25,6 +25,7 @@
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.NoSuchElementException;
 import java.util.Optional;
 import java.util.Set;
 import java.util.function.Function;
@@ -85,7 +86,7 @@ public Optional<BuildStep> step(MavenProject project, String name) {
     }
 
     public BuildStep requiredStep(MavenProject project, String name) {
-        return step(project, name).get();
+        return step(project, name).orElseThrow(() -> new NoSuchElementException("Step " + name + " not found"));
     }
 
     // add a follow-up plan to this one

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`	`import java.util.LinkedHashMap;`
`26`	`26`	`import java.util.List;`
`27`	`27`	`import java.util.Map;`
	`28`	`+import java.util.NoSuchElementException;`
`28`	`29`	`import java.util.Optional;`
`29`	`30`	`import java.util.Set;`
`30`	`31`	`import java.util.function.Function;`
`@@ -85,7 +86,7 @@ public Optional<BuildStep> step(MavenProject project, String name) {`
`85`	`86`	`}`
`86`	`87`
`87`	`88`	`public BuildStep requiredStep(MavenProject project, String name) {`
`88`		`- return step(project, name).get();`
	`89`	`+ return step(project, name).orElseThrow(() -> new NoSuchElementException("Step " + name + " not found"));`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`// add a follow-up plan to this one`