Commit 127929a
committed
Fix integration tests to properly validate unresolved repository expressions
- Remove premature expression validation from model validator
- Allow expressions to pass through model validation and fail at repository resolution time
- Update integration tests to use dependency:resolve instead of validate to trigger repository usage
- Add -e flag to integration tests to capture suppressed exception messages
- Update test expectations to match the corrected validation flow
The previous approach was rejecting expressions during model validation, but the correct
behavior is to allow expressions to pass through and fail when repositories are actually
used during dependency resolution. This matches the intended design where the MavenValidator
in the resolver catches uninterpolated expressions with the proper error message.1 parent 8ffdecd commit 127929a
4 files changed
Lines changed: 21 additions & 31 deletions
File tree
- impl/maven-impl/src
- main/java/org/apache/maven/impl/model
- test/java/org/apache/maven/impl/model
- its/core-it-suite/src/test/java/org/apache/maven/it
Lines changed: 12 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1590 | 1590 | | |
1591 | 1591 | | |
1592 | 1592 | | |
1593 | | - | |
1594 | | - | |
1595 | | - | |
1596 | | - | |
1597 | | - | |
1598 | | - | |
1599 | | - | |
1600 | | - | |
1601 | | - | |
1602 | | - | |
1603 | | - | |
1604 | | - | |
1605 | | - | |
1606 | | - | |
1607 | | - | |
1608 | | - | |
1609 | | - | |
1610 | | - | |
1611 | | - | |
1612 | | - | |
1613 | | - | |
1614 | | - | |
1615 | | - | |
| 1593 | + | |
| 1594 | + | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
| 1602 | + | |
| 1603 | + | |
| 1604 | + | |
1616 | 1605 | | |
1617 | 1606 | | |
1618 | 1607 | | |
| |||
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
895 | 895 | | |
896 | 896 | | |
897 | 897 | | |
898 | | - | |
899 | | - | |
900 | | - | |
| 898 | + | |
| 899 | + | |
901 | 900 | | |
902 | 901 | | |
903 | 902 | | |
904 | 903 | | |
905 | 904 | | |
906 | | - | |
907 | | - | |
| 905 | + | |
| 906 | + | |
908 | 907 | | |
909 | 908 | | |
910 | 909 | | |
| |||
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | | - | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
| 82 | + | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| |||
0 commit comments