Skip to content

Commit 0a666df

Browse files
committed
[MNG-8279] The project local repository and project collectors are using maven.multiModuleProjectDirectory instead of rootDirectory
1 parent fcb8147 commit 0a666df

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

maven-core/src/main/java/org/apache/maven/ReactorReader.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,8 @@ private boolean hasBeenPackagedDuringThisSession(MavenProject project) {
279279
}
280280

281281
private Path relativizeOutputFile(final Path outputFile) {
282-
Path projectBaseDirectory =
283-
Paths.get(session.getRequest().getMultiModuleProjectDirectory().toURI());
284-
return projectBaseDirectory.relativize(outputFile);
282+
Path rootDirectory = session.getRequest().getRootDirectory();
283+
return rootDirectory.relativize(outputFile);
285284
}
286285

287286
/**
@@ -445,7 +444,7 @@ private Path getArtifactPath(Artifact artifact) {
445444

446445
private Path getProjectLocalRepo() {
447446
if (projectLocalRepository == null) {
448-
Path root = session.getRequest().getMultiModuleProjectDirectory().toPath();
447+
Path root = session.getRequest().getRootDirectory();
449448
List<MavenProject> projects = session.getProjects();
450449
if (projects != null) {
451450
projectLocalRepository = projects.stream()

maven-core/src/main/java/org/apache/maven/project/collector/MultiModuleCollectionStrategy.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public MultiModuleCollectionStrategy(ModelLocator modelLocator, ProjectsSelector
6161

6262
@Override
6363
public List<MavenProject> collectProjects(MavenExecutionRequest request) throws ProjectBuildingException {
64-
File moduleProjectPomFile = getMultiModuleProjectPomFile(request);
64+
File moduleProjectPomFile = getRootProject(request);
6565
List<File> files = Collections.singletonList(moduleProjectPomFile.getAbsoluteFile());
6666
try {
6767
List<MavenProject> projects = projectsSelector.selectProjects(files, request);
@@ -96,24 +96,24 @@ public List<MavenProject> collectProjects(MavenExecutionRequest request) throws
9696
}
9797
}
9898

99-
private File getMultiModuleProjectPomFile(MavenExecutionRequest request) {
100-
File multiModuleProjectDirectory = request.getMultiModuleProjectDirectory();
101-
if (request.getPom().getParentFile().equals(multiModuleProjectDirectory)) {
99+
private File getRootProject(MavenExecutionRequest request) {
100+
File rootDirectory = request.getRootDirectory().toFile();
101+
if (request.getPom().getParentFile().equals(rootDirectory)) {
102102
return request.getPom();
103103
} else {
104-
File multiModuleProjectPom = modelLocator.locateExistingPom(multiModuleProjectDirectory);
105-
if (multiModuleProjectPom == null) {
104+
File rootProjectPom = modelLocator.locateExistingPom(rootDirectory);
105+
if (rootProjectPom == null) {
106106
LOGGER.info(
107107
"Maven detected that the requested POM file is part of a multi-module project, "
108-
+ "but could not find a pom.xml file in the multi-module root directory '{}'.",
109-
multiModuleProjectDirectory);
108+
+ "but could not find a pom.xml file in the root directory '{}'.",
109+
rootDirectory);
110110
LOGGER.info(
111111
"The reactor is limited to all projects under: {}",
112112
request.getPom().getParent());
113113
return request.getPom();
114114
}
115115

116-
return multiModuleProjectPom;
116+
return rootProjectPom;
117117
}
118118
}
119119

0 commit comments

Comments
 (0)