Skip to content

Commit 2ca95ee

Browse files
authored
Demote JDK transport (#1599)
Originally we have this order of transports w/ priorities (present/absent in maven core): * wagon -1.0 (present) * apache 5.0 (present) * jdk 10.0 (present) ("default" transport) * jetty 15.0 (absent) (if user added it via extension or lib/ext it "wins") But lately we see that JDK one advantage of HTTP/2 support (that is already disabled due various issues) is shaded due several disadvantages (no support for HTTPS proxies, unstable, and unreliable) Hence, I propose to "demote" it (maybe even remove it from Maven core): * wagon -1.0 (present) * jdk 5.0 (present; and maybe remove it from maven core) * apache 10.0 (present; new "default" transport) * jetty 15.0 (absent) This makes Maven 4 not have "modern" HTTP transport by default, but apache transport is well battle tested and robust, with one issue: lack of HTTP/2 support (that does improve download speeds). If we decide for this, it will have impact on Maven ITs as well that asser default transport.
1 parent 6e645ef commit 2ca95ee

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/ApacheTransporterFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
public final class ApacheTransporterFactory implements HttpTransporterFactory {
4040
public static final String NAME = "apache";
4141

42-
private float priority = 5.0f;
42+
private float priority = 10.0f;
4343

4444
private final ChecksumExtractor checksumExtractor;
4545

maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporterFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
public final class JdkTransporterFactory implements HttpTransporterFactory {
4141
public static final String NAME = "jdk";
4242

43-
private float priority = 10.0f;
43+
private float priority = 5.0f;
4444

4545
private final ChecksumExtractor checksumExtractor;
4646

maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-8/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporterFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public final class JdkTransporterFactory implements HttpTransporterFactory {
4444

4545
private static final Logger LOGGER = LoggerFactory.getLogger(JdkTransporterFactory.class);
4646

47-
private float priority = 10.0f;
47+
private float priority = 5.0f;
4848

4949
@Inject
5050
public JdkTransporterFactory(ChecksumExtractor checksumExtractor, PathProcessor pathProcessor) {

0 commit comments

Comments
 (0)