bugfix: support jdk9+ compile code (#4410)

Author: funky-eyes

changes/en-us/develop.md

@@ -10,6 +10,7 @@ Add changes here for all PR submitted to the develop branch.
 - [[#5991](https://github.com/seata/seata/pull/5991)] fix the issue that the Lua script is not synchronized when the redis sentinel master node is down
 - [[#6025](https://github.com/seata/seata/pull/6025)] fix the white screen after click the "View Global Lock" button on the transaction info page in the console
 - [[#6026](https://github.com/seata/seata/pull/6026)] fix incorrect metric report
+- [[#4410](https://github.com/seata/seata/pull/4410)] support jdk9+ compile code
 
 ### optimize:
 - [[#6044](https://github.com/seata/seata/pull/6044)] optimize derivative product check base on mysql
@@ -27,6 +28,7 @@ Thanks to these contributors for their code commits. Please report an unintended
 - [jsbxyyx](https://github.com/jsbxyyx)
 - [liuqiufeng](https://github.com/liuqiufeng)
 - [ptyin](https://github.com/ptyin)
+- [funky-eyes](https://github.com/funky-eyes)
 
 
 Also, we receive many valuable issues, questions and advices from our community. Thanks for you all.

changes/zh-cn/develop.md

@@ -10,6 +10,7 @@
 - [[#5991](https://github.com/seata/seata/pull/5991)] 修复redis sentinel master node 宕机时，lua脚本未同步的问题
 - [[#6025](https://github.com/seata/seata/pull/6025)] 修复控制台点击事务信息页面中的"查看全局锁"按钮之后白屏的问题
 - [[#6026](https://github.com/seata/seata/pull/6026)] 修复异常的打点
+- [[#4410](https://github.com/seata/seata/pull/4410)] 修复jdk9+版本编译后，引入后ByteBuffer#flip NoSuchMethodError的问题
 
 ### optimize:
 - [[#6044](https://github.com/seata/seata/pull/6044)] 优化MySQL衍生数据库判断逻辑
@@ -27,5 +28,6 @@
 - [jsbxyyx](https://github.com/jsbxyyx)
 - [liuqiufeng](https://github.com/liuqiufeng)
 - [ptyin](https://github.com/ptyin)
+- [funky-eyes](https://github.com/funky-eyes)
 
 同时，我们收到了社区反馈的很多有价值的issue和建议，非常感谢大家。

common/src/main/java/io/seata/common/util/BufferUtils.java

@@ -0,0 +1,93 @@
+/*
+ * Copyright 1999-2019 Seata.io Group.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
+ * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations under the License.
+ */
+package io.seata.common.util;
+
+import java.nio.Buffer;
+
+/**
+ * Explicit cast to {@link Buffer} parent buffer type. It resolves issues with covariant return types in Java 9+ for
+ * {@link java.nio.ByteBuffer} and {@link java.nio.CharBuffer}. Explicit casting resolves the NoSuchMethodErrors (e.g
+ * java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip(I)Ljava/nio/ByteBuffer) when the project is compiled with
+ * newer Java version and run on Java 8.
+ * <p/>
+ * <a href="https://docs.oracle.com/javase/8/docs/api/java/nio/ByteBuffer.html">Java 8</a> doesn't provide override the
+ * following Buffer methods in subclasses:
+ *
+ * <pre>
+ * Buffer clear()
+ * Buffer flip()
+ * Buffer limit(int newLimit)
+ * Buffer mark()
+ * Buffer position(int newPosition)
+ * Buffer reset()
+ * Buffer rewind()
+ * </pre>
+ *
+ * <a href="https://docs.oracle.com/javase/9/docs/api/java/nio/ByteBuffer.html">Java 9</a> introduces the overrides in
+ * child classes (e.g the ByteBuffer), but the return type is the specialized one and not the abstract {@link Buffer}.
+ * So the code compiled with newer Java is not working on Java 8 unless a workaround with explicit casting is used.
+ *
+ * @author funkye
+ */
+public class BufferUtils {
+
+    /**
+     * @param buffer byteBuffer
+     */
+    public static void flip(Buffer buffer) {
+        buffer.flip();
+    }
+
+    /**
+     * @param buffer byteBuffer
+     */
+    public static void clear(Buffer buffer) {
+        buffer.clear();
+    }
+
+    /**
+     * @param buffer byteBuffer
+     */
+    public static void limit(Buffer buffer, int newLimit) {
+        buffer.limit(newLimit);
+    }
+
+    /**
+     * @param buffer byteBuffer
+     */
+    public static void mark(Buffer buffer) {
+        buffer.mark();
+    }
+
+    /**
+     * @param buffer byteBuffer
+     */
+    public static void position(Buffer buffer, int newPosition) {
+        buffer.position(newPosition);
+    }
+
+    /**
+     * @param buffer byteBuffer
+     */
+    public static void rewind(Buffer buffer) {
+        buffer.rewind();
+    }
+
+    /**
+     * @param buffer byteBuffer
+     */
+    public static void reset(Buffer buffer) {
+        buffer.reset();
+    }
+
+}

integration/http/src/test/java/io/seata/integration/http/HttpTest.java

@@ -15,13 +15,6 @@
  */
 package io.seata.integration.http;
 
-import com.alibaba.fastjson.JSON;
-import com.alibaba.fastjson.JSONObject;
-import io.seata.core.context.RootContext;
-import org.apache.http.HttpResponse;
-import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Test;
-
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
@@ -31,6 +24,14 @@
 import java.nio.channels.WritableByteChannel;
 import java.util.HashMap;
 import java.util.Map;
+import com.alibaba.fastjson.JSON;
+import com.alibaba.fastjson.JSONObject;
+import io.seata.common.util.BufferUtils;
+import io.seata.core.context.RootContext;
+import org.apache.http.HttpResponse;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
 
 import static io.seata.integration.http.AbstractHttpExecutor.convertParamOfBean;
 import static io.seata.integration.http.AbstractHttpExecutor.convertParamOfJsonString;
@@ -205,7 +206,7 @@ public static String readStreamAsStr(InputStream is) throws IOException {
         ByteBuffer bb = ByteBuffer.allocate(4096);
 
         while (src.read(bb) != -1) {
-            bb.flip();
+            BufferUtils.flip(bb);
             dest.write(bb);
             bb.clear();
         }

rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/ProtostuffUndoLogParser.java

@@ -20,6 +20,9 @@
 import java.sql.Timestamp;
 import java.util.List;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import io.protostuff.Input;
 import io.protostuff.LinkedBuffer;
 import io.protostuff.Output;
@@ -36,11 +39,10 @@
 import io.seata.common.loader.EnhancedServiceNotFoundException;
 import io.seata.common.loader.LoadLevel;
 import io.seata.common.util.CollectionUtils;
+import io.seata.common.util.BufferUtils;
 import io.seata.rm.datasource.undo.BranchUndoLog;
 import io.seata.rm.datasource.undo.UndoLogParser;
 import io.seata.rm.datasource.undo.parser.spi.ProtostuffDelegate;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * The type protostuff based undo log parser.
@@ -132,7 +134,7 @@ public java.sql.Timestamp readFrom(Input input) throws IOException {
             ByteBuffer buffer = input.readByteBuffer();
             long time = buffer.getLong();
             int nanos = buffer.getInt();
-            buffer.flip();
+            BufferUtils.flip(buffer);
             java.sql.Timestamp timestamp = new Timestamp(time);
             timestamp.setNanos(nanos);
             return timestamp;
@@ -143,7 +145,7 @@ public void writeTo(Output output, int number, java.sql.Timestamp value, boolean
             ByteBuffer buffer = ByteBuffer.allocate(12);
             buffer.putLong(value.getTime());
             buffer.putInt(value.getNanos());
-            buffer.flip();
+            BufferUtils.flip(buffer);
             output.writeBytes(number, buffer, repeated);
         }
 

serializer/seata-serializer-protobuf/src/main/java/io/seata/serializer/protobuf/ProtobufSerializer.java

@@ -15,16 +15,18 @@
  */
 package io.seata.serializer.protobuf;
 
+import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+
 import com.google.protobuf.GeneratedMessageV3;
+
 import io.seata.common.loader.LoadLevel;
+import io.seata.common.util.BufferUtils;
 import io.seata.core.serializer.Serializer;
 import io.seata.serializer.protobuf.convertor.PbConvertor;
 import io.seata.serializer.protobuf.manager.ProtobufConvertManager;
 
-import java.nio.ByteBuffer;
-import java.nio.charset.Charset;
-import java.nio.charset.StandardCharsets;
-
 /**
  * The type Protobuf codec.
  *
@@ -53,7 +55,7 @@ public <T> byte[] serialize(T t) {
         byteBuffer.putInt(nameBytes.length);
         byteBuffer.put(nameBytes);
         byteBuffer.put(body);
-        byteBuffer.flip();
+        BufferUtils.flip(byteBuffer);
         byte[] content = new byte[byteBuffer.limit()];
         byteBuffer.get(content);
         return content;

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java

@@ -15,14 +15,15 @@
  */
 package io.seata.serializer.seata;
 
+import java.nio.ByteBuffer;
+
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import io.seata.common.loader.LoadLevel;
+import io.seata.common.util.BufferUtils;
 import io.seata.core.protocol.AbstractMessage;
 import io.seata.core.serializer.Serializer;
 
-import java.nio.ByteBuffer;
-
 /**
  * The Seata codec.
  *
@@ -53,7 +54,7 @@ public <T> byte[] serialize(T t) {
         byteBuffer.putShort(typecode);
         byteBuffer.put(body);
 
-        byteBuffer.flip();
+        BufferUtils.flip(byteBuffer);
         byte[] content = new byte[byteBuffer.limit()];
         byteBuffer.get(content);
         return content;

server/src/main/java/io/seata/server/session/BranchSession.java

@@ -21,6 +21,7 @@
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
 import io.seata.common.util.CompressUtil;
+import io.seata.common.util.BufferUtils;
 import io.seata.core.exception.TransactionException;
 import io.seata.core.model.BranchStatus;
 import io.seata.core.model.BranchType;
@@ -350,7 +351,7 @@ public byte[] encode() {
 
         ByteBuffer byteBuffer = byteBufferThreadLocal.get();
         //recycle
-        byteBuffer.clear();
+        BufferUtils.clear(byteBuffer);
 
         byteBuffer.putLong(transactionId);
         byteBuffer.putLong(branchId);
@@ -394,7 +395,7 @@ public byte[] encode() {
 
         byteBuffer.put((byte)status.getCode());
         byteBuffer.put((byte)lockStatus.getCode());
-        byteBuffer.flip();
+        BufferUtils.flip(byteBuffer);
         byte[] result = new byte[byteBuffer.limit()];
         byteBuffer.get(result);
         return result;

server/src/main/java/io/seata/server/session/GlobalSession.java

@@ -29,6 +29,7 @@
 import io.seata.common.Constants;
 import io.seata.common.DefaultValues;
 import io.seata.common.XID;
+import io.seata.common.util.BufferUtils;
 import io.seata.common.util.StringUtils;
 import io.seata.config.ConfigurationFactory;
 import io.seata.core.constants.ConfigurationKeys;
@@ -46,6 +47,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+
 import static io.seata.core.model.GlobalStatus.AsyncCommitting;
 import static io.seata.core.model.GlobalStatus.CommitRetrying;
 import static io.seata.core.model.GlobalStatus.Committing;
@@ -584,7 +586,7 @@ public byte[] encode() {
         }
         ByteBuffer byteBuffer = byteBufferThreadLocal.get();
         //recycle
-        byteBuffer.clear();
+        BufferUtils.clear(byteBuffer);
 
         byteBuffer.putLong(transactionId);
         byteBuffer.putInt(timeout);
@@ -621,7 +623,7 @@ public byte[] encode() {
 
         byteBuffer.putLong(beginTime);
         byteBuffer.put((byte)status.getCode());
-        byteBuffer.flip();
+        BufferUtils.flip(byteBuffer);
         byte[] result = new byte[byteBuffer.limit()];
         byteBuffer.get(result);
         return result;

server/src/main/java/io/seata/server/storage/file/store/FileTransactionStoreManager.java

@@ -31,10 +31,10 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.locks.ReentrantLock;
-
 import io.seata.common.exception.StoreException;
 import io.seata.common.thread.NamedThreadFactory;
 import io.seata.common.util.CollectionUtils;
+import io.seata.common.util.BufferUtils;
 import io.seata.server.session.BranchSession;
 import io.seata.server.session.GlobalSession;
 import io.seata.server.session.SessionCondition;
@@ -50,6 +50,7 @@
 import org.slf4j.LoggerFactory;
 import org.slf4j.MDC;
 
+
 import static io.seata.core.context.RootContext.MDC_KEY_BRANCH_ID;
 
 /**
@@ -263,11 +264,11 @@ private boolean writeDataFrame(byte[] data) {
     }
 
     private boolean flushWriteBuffer(ByteBuffer writeBuffer) {
-        writeBuffer.flip();
+        BufferUtils.flip(writeBuffer);
         if (!writeDataFileByBuffer(writeBuffer)) {
             return false;
         }
-        writeBuffer.clear();
+        BufferUtils.clear(writeBuffer);
         return true;
     }
 
@@ -397,12 +398,12 @@ private List<TransactionWriteStore> parseDataFile(File file, int readSize, long
             ByteBuffer buffSize = ByteBuffer.allocate(MARK_SIZE);
             while (fileChannel.position() < size) {
                 try {
-                    buffSize.clear();
+                    BufferUtils.clear(buffSize);
                     int avilReadSize = fileChannel.read(buffSize);
                     if (avilReadSize != MARK_SIZE) {
                         break;
                     }
-                    buffSize.flip();
+                    BufferUtils.flip(buffSize);
                     int bodySize = buffSize.getInt();
                     byte[] byBody = new byte[bodySize];
                     ByteBuffer buffBody = ByteBuffer.wrap(byBody);