Skip to content

Commit dad16d1

Browse files
author
Alexey Kudinkin
committed
Tidying up
1 parent 9a230b7 commit dad16d1

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark3Analysis.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ import scala.collection.JavaConverters.mapAsJavaMapConverter
4545
* Since Hudi relations don't currently implement DS V2 Read API, we have to fallback to V1 here.
4646
* Such fallback will have considerable performance impact, therefore it's only performed in cases
4747
* where V2 API have to be used. Currently only such use-case is using of Schema Evolution feature
48+
*
49+
* Check out HUDI-4178 for more details
4850
*/
4951
class HoodieDataSourceV2ToV1Fallback(sparkSession: SparkSession) extends Rule[LogicalPlan]
5052
with ProvidesHoodieConfig {
@@ -129,7 +131,6 @@ class HoodieSpark3Analysis(sparkSession: SparkSession) extends Rule[LogicalPlan]
129131

130132
/**
131133
* Rule for resolve hoodie's extended syntax or rewrite some logical plan.
132-
* @param sparkSession
133134
*/
134135
case class HoodieSpark3ResolveReferences(sparkSession: SparkSession) extends Rule[LogicalPlan]
135136
with SparkAdapterSupport with ProvidesHoodieConfig {

hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,14 @@ class HoodieCatalog extends DelegatingCatalogExtension
115115

116116
val schemaEvolutionEnabled: Boolean = spark.sessionState.conf.getConfString(DataSourceReadOptions.SCHEMA_EVOLUTION_ENABLED.key,
117117
DataSourceReadOptions.SCHEMA_EVOLUTION_ENABLED.defaultValue.toString).toBoolean
118-
// TODO elaborate
118+
119+
// NOTE: PLEASE READ CAREFULLY
120+
//
121+
// Since Hudi relations don't currently implement DS V2 Read API, we by default fallback to V1 here.
122+
// Such fallback will have considerable performance impact, therefore it's only performed in cases
123+
// where V2 API have to be used. Currently only such use-case is using of Schema Evolution feature
124+
//
125+
// Check out HUDI-4178 for more details
119126
if (schemaEvolutionEnabled) {
120127
v2Table
121128
} else {

0 commit comments

Comments
 (0)