Skip to content

Commit 962bfff

Browse files
committed
Add test for hudi-cli rollbackUsingMarkers
1 parent 1d3b941 commit 962bfff

2 files changed

Lines changed: 20 additions & 0 deletions

File tree

hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRollbacksCommand.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
import org.apache.hudi.index.HoodieIndex;
4141
import org.apache.hudi.metadata.SparkHoodieBackedTableMetadataWriter;
4242

43+
import org.apache.log4j.LogManager;
44+
import org.apache.log4j.Logger;
4345
import org.junit.jupiter.api.BeforeEach;
4446
import org.junit.jupiter.api.Tag;
4547
import org.junit.jupiter.api.Test;
@@ -65,6 +67,7 @@
6567
*/
6668
@Tag("functional")
6769
public class TestRollbacksCommand extends CLIFunctionalTestHarness {
70+
private static final Logger LOG = LogManager.getLogger(TestRollbacksCommand.class);
6871

6972
@BeforeEach
7073
public void init() throws Exception {

hudi-cli/src/test/java/org/apache/hudi/cli/integ/ITTestCommitsCommand.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,5 +125,22 @@ public void testRollbackCommit() throws Exception {
125125

126126
HoodieActiveTimeline timeline2 = metaClient.reloadActiveTimeline();
127127
assertEquals(1, timeline2.getCommitsTimeline().countInstants(), "There should have 1 instants.");
128+
129+
// rollback with rollbackUsingMarkers==false
130+
CommandResult cr3 = getShell().executeCommand(
131+
String.format("commit rollback --commit %s --rollbackUsingMarkers false --sparkMaster %s --sparkMemory %s",
132+
"100", "local", "4G"));
133+
134+
assertAll("Command run failed",
135+
() -> assertTrue(cr3.isSuccess()),
136+
() -> assertEquals("Commit 100 rolled back", cr3.getResult().toString()));
137+
138+
metaClient = HoodieTableMetaClient.reload(HoodieCLI.getTableMetaClient());
139+
140+
HoodieActiveTimeline rollbackTimeline3 = new RollbacksCommand.RollbackTimeline(metaClient);
141+
assertEquals(3, rollbackTimeline3.getRollbackTimeline().countInstants(), "There should have 3 rollback instant.");
142+
143+
HoodieActiveTimeline timeline3 = metaClient.reloadActiveTimeline();
144+
assertEquals(0, timeline3.getCommitsTimeline().countInstants(), "There should have 0 instants.");
128145
}
129146
}

0 commit comments

Comments
 (0)