From 2dae3070af84ef2e90cb70c46175588a386149f1 Mon Sep 17 00:00:00 2001 From: Caroline Zhou Date: Wed, 9 Dec 2020 23:13:54 -0800 Subject: [PATCH 1/3] HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time --- .../hadoop/hbase/master/assignment/AssignmentManager.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java index 4d0e165456d1..5f066fcdaf89 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java @@ -1425,6 +1425,13 @@ protected void update(final AssignmentManager am) { this.statTimestamp = EnvironmentEdgeManager.currentTime(); update(regionStates.getRegionsStateInTransition(), statTimestamp); update(regionStates.getRegionFailedOpen(), statTimestamp); + + if (ritsOverThreshold != null && !ritsOverThreshold.isEmpty()) { + LOG.trace("RIT hashes and states: " + + ritsOverThreshold.entrySet().stream() + .map(e -> e.getKey() + ":" + e.getValue().getState().name()) + .collect(Collectors.joining("\n"))); + } } private void update(final Collection regions, final long currentTime) { From fcbb912ce8dd53cf2d0c4864844a3d6abe746ca1 Mon Sep 17 00:00:00 2001 From: Caroline Zhou Date: Mon, 11 Jan 2021 23:09:13 -0800 Subject: [PATCH 2/3] format --- .../hadoop/hbase/master/assignment/AssignmentManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java index 5f066fcdaf89..7a00265e3006 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java @@ -1427,7 +1427,7 @@ protected void update(final AssignmentManager am) { update(regionStates.getRegionFailedOpen(), statTimestamp); if (ritsOverThreshold != null && !ritsOverThreshold.isEmpty()) { - LOG.trace("RIT hashes and states: " + + LOG.trace("RIT hashes and states: {}", ritsOverThreshold.entrySet().stream() .map(e -> e.getKey() + ":" + e.getValue().getState().name()) .collect(Collectors.joining("\n"))); From aff33fd7777c493a13b0558cd7ebd80a46c943da Mon Sep 17 00:00:00 2001 From: Caroline Zhou Date: Tue, 12 Jan 2021 09:53:29 -0800 Subject: [PATCH 3/3] trace -> debug --- .../hadoop/hbase/master/assignment/AssignmentManager.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java index 7a00265e3006..1eb39028f454 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java @@ -1426,8 +1426,8 @@ protected void update(final AssignmentManager am) { update(regionStates.getRegionsStateInTransition(), statTimestamp); update(regionStates.getRegionFailedOpen(), statTimestamp); - if (ritsOverThreshold != null && !ritsOverThreshold.isEmpty()) { - LOG.trace("RIT hashes and states: {}", + if (LOG.isDebugEnabled() && ritsOverThreshold != null && !ritsOverThreshold.isEmpty()) { + LOG.debug("RITs over threshold: {}", ritsOverThreshold.entrySet().stream() .map(e -> e.getKey() + ":" + e.getValue().getState().name()) .collect(Collectors.joining("\n")));