HBASE-23625 Reduced number of Checkstyle violations in hbase-common

Signed-off-by: Viraj Jasani <[email protected]>

Author: HorizonNet

hbase-common/src/main/java/org/apache/hadoop/hbase/CellScanner.java

@@ -15,14 +15,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 package org.apache.hadoop.hbase;
 
 import java.io.IOException;
 
 import org.apache.hadoop.hbase.classification.InterfaceAudience;
 import org.apache.hadoop.hbase.classification.InterfaceStability;
-import org.apache.hadoop.hbase.Cell;
 
 /**
  * An interface for iterating through a sequence of cells. Similar to Java's Iterator, but without
@@ -59,7 +57,7 @@ public interface CellScanner {
   /**
    * Advance the scanner 1 cell.
    * @return true if the next cell is found and {@link #current()} will return a valid Cell
-   * @throws IOException
+   * @throws IOException if advancing the scanner fails
    */
   boolean advance() throws IOException;
 }

hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractByteRange.java

@@ -59,7 +59,6 @@
 @InterfaceAudience.Private
 @InterfaceStability.Evolving
 public abstract class AbstractByteRange implements ByteRange {
-
   public static final int UNSET_HASH_VALUE = -1;
 
   // Note to maintainers: Do not make these final, as the intention is to
@@ -95,18 +94,17 @@ public byte[] getBytes() {
     return bytes;
   }
 
-  @Override
-  public abstract ByteRange unset();
-
   @Override
   public ByteRange set(int capacity) {
     return set(new byte[capacity]);
   }
 
   @Override
   public ByteRange set(byte[] bytes) {
-    if (null == bytes)
+    if (null == bytes) {
       return unset();
+    }
+
     clearHashCache();
     this.bytes = bytes;
     this.offset = 0;
@@ -116,8 +114,10 @@ public ByteRange set(byte[] bytes) {
 
   @Override
   public ByteRange set(byte[] bytes, int offset, int length) {
-    if (null == bytes)
+    if (null == bytes) {
       return unset();
+    }
+
     clearHashCache();
     this.bytes = bytes;
     this.offset = offset;
@@ -172,15 +172,19 @@ public byte get(int index) {
 
   @Override
   public ByteRange get(int index, byte[] dst) {
-    if (0 == dst.length)
+    if (0 == dst.length) {
       return this;
+    }
+
     return get(index, dst, 0, dst.length);
   }
 
   @Override
   public ByteRange get(int index, byte[] dst, int offset, int length) {
-    if (0 == length)
+    if (0 == length) {
       return this;
+    }
+
     System.arraycopy(this.bytes, this.offset + index, dst, offset, length);
     return this;
   }
@@ -243,27 +247,6 @@ public static int getVLongSize(long val) {
     return rPos + 1;
   }
 
-  @Override
-  public abstract ByteRange put(int index, byte val);
-
-  @Override
-  public abstract ByteRange put(int index, byte[] val);
-
-  @Override
-  public abstract ByteRange put(int index, byte[] val, int offset, int length);
-
-  @Override
-  public abstract ByteRange putInt(int index, int val);
-
-  @Override
-  public abstract ByteRange putLong(int index, long val);
-
-  @Override
-  public abstract ByteRange putShort(int index, short val);
-
-  @Override
-  public abstract int putVLong(int index, long val);
-
   //
   // methods for duplicating the current instance
   //

hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractPositionedByteRange.java

@@ -17,12 +17,9 @@
  */
 package org.apache.hadoop.hbase.util;
 
-
 import org.apache.hadoop.hbase.classification.InterfaceAudience;
 import org.apache.hadoop.hbase.classification.InterfaceStability;
 
-import com.google.common.annotations.VisibleForTesting;
-
 /**
  * Extends the basic {@link SimpleByteRange} implementation with position
  * support. {@code position} is considered transient, not fundamental to the
@@ -48,9 +45,6 @@ public abstract class AbstractPositionedByteRange extends AbstractByteRange impl
 
   protected int limit = 0;
 
-  @Override
-  public abstract PositionedByteRange unset();
-
   @Override
   public PositionedByteRange set(int capacity) {
     this.position = 0;
@@ -134,77 +128,24 @@ public byte get() {
 
   @Override
   public PositionedByteRange get(byte[] dst) {
-    if (0 == dst.length)
+    if (0 == dst.length) {
       return this;
-    return this.get(dst, 0, dst.length); // be clear we're calling self, not
-                                         // super
+    }
+
+    return this.get(dst, 0, dst.length); // be clear we're calling self, not super
   }
 
   @Override
   public PositionedByteRange get(byte[] dst, int offset, int length) {
-    if (0 == length)
+    if (0 == length) {
       return this;
+    }
+
     super.get(this.position, dst, offset, length);
     this.position += length;
     return this;
   }
 
-  @Override
-  public abstract PositionedByteRange put(byte val);
-
-  @Override
-  public abstract PositionedByteRange put(byte[] val);
-
-  @Override
-  public abstract PositionedByteRange put(byte[] val, int offset, int length);
-
-  @Override
-  public abstract PositionedByteRange putInt(int index, int val);
-
-  @Override
-  public abstract PositionedByteRange putLong(int index, long val);
-
-  @Override
-  public abstract PositionedByteRange putShort(int index, short val);
-
-  @Override
-  public abstract PositionedByteRange putInt(int val);
-
-  @Override
-  public abstract PositionedByteRange putLong(long val);
-
-  @Override
-  public abstract PositionedByteRange putShort(short val);
-
-  @Override
-  public abstract int putVLong(int index, long val);
-
-  @Override
-  public abstract int putVLong(long val);
-  /**
-   * Similar to {@link java.nio.ByteBuffer#flip()}. Sets length to position, position to
-   * offset.
-   */
-  @VisibleForTesting
-  PositionedByteRange flip() {
-    clearHashCache();
-    length = position;
-    position = offset;
-    return this;
-  }
-
-  /**
-   * Similar to {@link java.nio.ByteBuffer#clear()}. Sets position to 0, length to
-   * capacity.
-   */
-  @VisibleForTesting
-  PositionedByteRange clear() {
-    clearHashCache();
-    position = 0;
-    length = bytes.length - offset;
-    return this;
-  }
-
   // java boilerplate
 
   @Override
@@ -247,24 +188,6 @@ public long getVLong() {
     return p;
   }
 
-  @Override
-  public abstract PositionedByteRange put(int index, byte val);
-
-  @Override
-  public abstract PositionedByteRange put(int index, byte[] val);
-
-  @Override
-  public abstract PositionedByteRange put(int index, byte[] val, int offset, int length);
-
-  @Override
-  public abstract PositionedByteRange deepCopy();
-
-  @Override
-  public abstract PositionedByteRange shallowCopy();
-
-  @Override
-  public abstract PositionedByteRange shallowCopySubRange(int innerOffset, int copyLength);
-
   @Override
   public PositionedByteRange setLimit(int limit) {
     this.limit = limit;

hbase-common/src/main/java/org/apache/hadoop/hbase/util/AtomicUtils.java

@@ -25,7 +25,10 @@
  * Utilities related to atomic operations.
  */
 @InterfaceAudience.Private
-public class AtomicUtils {
+public final class AtomicUtils {
+  private AtomicUtils() {
+  }
+
   /**
    * Updates a AtomicLong which is supposed to maintain the minimum values. This method is not
    * synchronized but is thread-safe.
@@ -59,5 +62,4 @@ public static void updateMax(AtomicLong max, long value) {
       }
     }
   }
-
 }