Skip to content

Commit da0dfb6

Browse files
committed
Fix checkstyle issues
1 parent 45ec211 commit da0dfb6

2 files changed

Lines changed: 19 additions & 24 deletions

File tree

hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,6 @@
2020

2121
import static org.apache.hadoop.hbase.ipc.IPCUtil.toIOE;
2222
import static org.apache.hadoop.hbase.ipc.IPCUtil.wrapException;
23-
24-
import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
25-
import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
26-
import org.apache.hbase.thirdparty.com.google.common.cache.CacheBuilder;
27-
import org.apache.hbase.thirdparty.com.google.common.cache.CacheLoader;
28-
import org.apache.hbase.thirdparty.com.google.common.cache.LoadingCache;
29-
import org.apache.hbase.thirdparty.com.google.protobuf.BlockingRpcChannel;
30-
import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
31-
import org.apache.hbase.thirdparty.com.google.protobuf.Message;
32-
import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel;
33-
import org.apache.hbase.thirdparty.com.google.protobuf.RpcController;
34-
import org.apache.hbase.thirdparty.com.google.protobuf.ServiceException;
35-
import org.apache.hbase.thirdparty.com.google.protobuf.RpcCallback;
36-
37-
import org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer;
38-
3923
import java.io.IOException;
4024
import java.net.InetSocketAddress;
4125
import java.net.SocketAddress;
@@ -52,14 +36,9 @@
5236
import java.util.concurrent.ScheduledFuture;
5337
import java.util.concurrent.TimeUnit;
5438
import java.util.concurrent.atomic.AtomicInteger;
55-
56-
import java.util.stream.Collectors;
5739
import org.apache.hadoop.conf.Configuration;
5840
import org.apache.hadoop.hbase.HConstants;
5941
import org.apache.hadoop.hbase.ServerName;
60-
import org.apache.yetus.audience.InterfaceAudience;
61-
import org.slf4j.Logger;
62-
import org.slf4j.LoggerFactory;
6342
import org.apache.hadoop.hbase.client.MetricsConnection;
6443
import org.apache.hadoop.hbase.codec.Codec;
6544
import org.apache.hadoop.hbase.codec.KeyValueCodec;
@@ -74,7 +53,22 @@
7453
import org.apache.hadoop.ipc.RemoteException;
7554
import org.apache.hadoop.security.token.TokenIdentifier;
7655
import org.apache.hadoop.security.token.TokenSelector;
77-
56+
import org.apache.yetus.audience.InterfaceAudience;
57+
import org.slf4j.Logger;
58+
import org.slf4j.LoggerFactory;
59+
import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
60+
import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
61+
import org.apache.hbase.thirdparty.com.google.common.cache.CacheBuilder;
62+
import org.apache.hbase.thirdparty.com.google.common.cache.CacheLoader;
63+
import org.apache.hbase.thirdparty.com.google.common.cache.LoadingCache;
64+
import org.apache.hbase.thirdparty.com.google.protobuf.BlockingRpcChannel;
65+
import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
66+
import org.apache.hbase.thirdparty.com.google.protobuf.Message;
67+
import org.apache.hbase.thirdparty.com.google.protobuf.RpcCallback;
68+
import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel;
69+
import org.apache.hbase.thirdparty.com.google.protobuf.RpcController;
70+
import org.apache.hbase.thirdparty.com.google.protobuf.ServiceException;
71+
import org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer;
7872
import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
7973

8074
/**
@@ -234,7 +228,9 @@ private void cleanupIdleConnections() {
234228
// have some pending calls on connection so we should not shutdown the connection outside.
235229
// The connection itself will disconnect if there is no pending call for maxIdleTime.
236230
if (conn.getLastTouched() < closeBeforeTime && !conn.isActive()) {
237-
if (LOG.isTraceEnabled()) LOG.trace("Cleanup idle connection to " + conn.remoteId().address);
231+
if (LOG.isTraceEnabled()) {
232+
LOG.trace("Cleanup idle connection to " + conn.remoteId().address);
233+
}
238234
connections.removeValue(conn.remoteId(), conn);
239235
conn.cleanupConnection();
240236
}

hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.util.Objects;
2626
import java.util.regex.Matcher;
2727
import java.util.regex.Pattern;
28-
import java.util.stream.Collectors;
2928
import org.apache.hadoop.hbase.HConstants;
3029
import org.apache.hadoop.hbase.exceptions.HBaseException;
3130
import org.apache.yetus.audience.InterfaceAudience;

0 commit comments

Comments
 (0)