Skip to content

Commit d8247eb

Browse files
authored
HBASE-24524 SyncTable logging improvements (#1878)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
1 parent 1eb159b commit d8247eb

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

  • hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce

hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/SyncTable.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -364,16 +364,16 @@ private void syncRange(Context context, ImmutableBytesWritable startRow,
364364
boolean rowMatched;
365365
int rowComparison = compareRowKeys(nextSourceRow, nextTargetRow);
366366
if (rowComparison < 0) {
367-
if (LOG.isInfoEnabled()) {
368-
LOG.info("Target missing row: " + Bytes.toHex(nextSourceRow));
367+
if (LOG.isDebugEnabled()) {
368+
LOG.debug("Target missing row: " + Bytes.toString(nextSourceRow));
369369
}
370370
context.getCounter(Counter.TARGETMISSINGROWS).increment(1);
371371

372372
rowMatched = syncRowCells(context, nextSourceRow, sourceCells, EMPTY_CELL_SCANNER);
373373
nextSourceRow = sourceCells.nextRow(); // advance only source to next row
374374
} else if (rowComparison > 0) {
375-
if (LOG.isInfoEnabled()) {
376-
LOG.info("Source missing row: " + Bytes.toHex(nextTargetRow));
375+
if (LOG.isDebugEnabled()) {
376+
LOG.debug("Source missing row: " + Bytes.toString(nextTargetRow));
377377
}
378378
context.getCounter(Counter.SOURCEMISSINGROWS).increment(1);
379379

@@ -558,10 +558,10 @@ private boolean syncRowCells(Context context, byte[] rowKey, CellScanner sourceC
558558
if (LOG.isDebugEnabled()) {
559559
LOG.debug("Different values: ");
560560
LOG.debug(" source cell: " + sourceCell
561-
+ " value: " + Bytes.toHex(sourceCell.getValueArray(),
561+
+ " value: " + Bytes.toString(sourceCell.getValueArray(),
562562
sourceCell.getValueOffset(), sourceCell.getValueLength()));
563563
LOG.debug(" target cell: " + targetCell
564-
+ " value: " + Bytes.toHex(targetCell.getValueArray(),
564+
+ " value: " + Bytes.toString(targetCell.getValueArray(),
565565
targetCell.getValueOffset(), targetCell.getValueLength()));
566566
}
567567
context.getCounter(Counter.DIFFERENTCELLVALUES).increment(1);

0 commit comments

Comments
 (0)