Skip to content

Commit d218c57

Browse files
committed
Minor test fix
1 parent 12f1d39 commit d218c57

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
@InterfaceAudience.Private
8888
public class IncrementalTableBackupClient extends TableBackupClient {
8989
private static final Logger LOG = LoggerFactory.getLogger(IncrementalTableBackupClient.class);
90+
private static final String BULKLOAD_COLLECTOR_OUTPUT = "bulkload-collector-output";
9091

9192
protected IncrementalTableBackupClient() {
9293
}
@@ -202,7 +203,7 @@ protected List<BulkLoad> handleBulkLoad(List<TableName> tablesToBackup,
202203
}
203204
} else {
204205
// Continuous incremental backup: run BulkLoadCollectorJob over backed-up WALs
205-
Path collectorOutput = new Path(getBulkOutputDir(), "bulkload-collector-output");
206+
Path collectorOutput = new Path(getBulkOutputDir(), BULKLOAD_COLLECTOR_OUTPUT);
206207
for (TableName table : tablesToBackup) {
207208
String walDirsCsv = String.join(",", tablesToWALFileList.get(table));
208209

hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupWithContinuous.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,22 +163,17 @@ public void testIncrementalBackupCopyingBulkloadTillIncrCommittedWalTs() throws
163163
performBulkLoad("bulkPreIncr", methodName, tableName1);
164164
expectedRowCount += ROWS_IN_BULK_LOAD;
165165
assertEquals(expectedRowCount, TEST_UTIL.countRows(tableName1));
166-
//assertEquals(1, systemTable.readBulkloadRows(List.of(tableName1)).size());
167166
assertTrue(systemTable.readBulkloadRows(List.of(tableName1)).isEmpty());
168167
loadTable(TEST_UTIL.getConnection().getTable(tableName1));
169168
Thread.sleep(15000);
170169

171170
performBulkLoad("bulkPostIncr", methodName, tableName1);
172-
//assertEquals(2, systemTable.readBulkloadRows(List.of(tableName1)).size());
173171
assertTrue(systemTable.readBulkloadRows(List.of(tableName1)).isEmpty());
174172

175173
// Incremental backup
176174
String backup2 =
177175
backupTables(BackupType.INCREMENTAL, List.of(tableName1), BACKUP_ROOT_DIR, true);
178176
assertTrue(checkSucceeded(backup2));
179-
180-
// bulkPostIncr Bulkload entry should not be deleted post incremental backup
181-
//assertEquals(1, systemTable.readBulkloadRows(List.of(tableName1)).size());
182177
assertTrue(systemTable.readBulkloadRows(List.of(tableName1)).isEmpty());
183178

184179
TEST_UTIL.truncateTable(tableName1);

0 commit comments

Comments
 (0)