Skip to content

Commit 6a7fe01

Browse files
author
Prathyusha Garre
committed
HBASE-27938 - fix checkstyle errors
1 parent 753391a commit 6a7fe01

1 file changed

Lines changed: 16 additions & 10 deletions

File tree

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -360,11 +360,14 @@ static boolean checkTable(Admin admin, TestOptions opts) throws IOException {
360360
// recreate the table when user has requested presplit or when existing
361361
// {RegionSplitPolicy,replica count} does not match requested, or when the
362362
// number of column families does not match requested.
363-
if ((exists && opts.presplitRegions != DEFAULT_OPTS.presplitRegions
363+
if (
364+
(exists && opts.presplitRegions != DEFAULT_OPTS.presplitRegions
364365
&& opts.presplitRegions != admin.getRegions(tableName).size())
365-
|| (!isReadCmd && desc != null && !StringUtils.equals(desc.getRegionSplitPolicyClassName(), opts.splitPolicy))
366+
|| (!isReadCmd && desc != null
367+
&& !StringUtils.equals(desc.getRegionSplitPolicyClassName(), opts.splitPolicy))
366368
|| (!isReadCmd && desc != null && desc.getRegionReplication() != opts.replicas)
367-
|| (desc != null && desc.getColumnFamilyCount() != opts.families)) {
369+
|| (desc != null && desc.getColumnFamilyCount() != opts.families)
370+
) {
368371
needsDelete = true;
369372
// wait, why did it delete my table?!?
370373
LOG.debug(MoreObjects.toStringHelper("needsDelete").add("needsDelete", needsDelete)
@@ -786,11 +789,11 @@ public TestOptions(TestOptions that) {
786789
this.bufferSize = that.bufferSize;
787790
this.commandProperties = that.commandProperties;
788791
}
789-
792+
790793
public Properties getCommandProperties() {
791794
return commandProperties;
792795
}
793-
796+
794797
public int getCaching() {
795798
return this.caching;
796799
}
@@ -2686,7 +2689,8 @@ protected static void printUsage(final String shortName, final String message) {
26862689
for (CmdDescriptor command : COMMANDS.values()) {
26872690
System.err.println(String.format(" %-20s %s", command.getName(), command.getDescription()));
26882691
}
2689-
System.err.println(String.format(" %-20s %s", "? extends Test", "Run custom implementation of provided Test present in classpath"));
2692+
System.err.println(String.format(" %-20s %s", "? extends Test",
2693+
"Run custom implementation of provided Test present in classpath"));
26902694
System.err.println();
26912695
System.err.println("Args:");
26922696
System.err.println(" nclients Integer. Required. Total number of clients "
@@ -2987,14 +2991,15 @@ static TestOptions parseOpts(Queue<String> args) {
29872991
String fileName = String.valueOf(cmd.substring(commandPropertiesFile.length()));
29882992
Properties properties = new Properties();
29892993
try {
2990-
properties.load(PerformanceEvaluation.class.getClassLoader().getResourceAsStream(fileName));
2994+
properties
2995+
.load(PerformanceEvaluation.class.getClassLoader().getResourceAsStream(fileName));
29912996
opts.commandProperties = properties;
29922997
} catch (IOException e) {
29932998
LOG.error("Failed to load metricIds from properties file", e);
29942999
}
29953000
continue;
29963001
}
2997-
3002+
29983003
validateParsedOpts(opts);
29993004

30003005
if (isCommandClass(cmd)) {
@@ -3114,15 +3119,16 @@ private static boolean isCommandClass(String cmd) {
31143119
private static boolean isCustomTestClass(String cmd) {
31153120
Class<? extends Test> cmdClass;
31163121
try {
3117-
cmdClass = (Class<? extends Test>) PerformanceEvaluation.class.getClassLoader().loadClass(cmd);
3122+
cmdClass =
3123+
(Class<? extends Test>) PerformanceEvaluation.class.getClassLoader().loadClass(cmd);
31183124
addCommandDescriptor(cmdClass, cmd, "custom command");
31193125
return true;
31203126
} catch (Throwable th) {
31213127
LOG.info("No class found for command: " + cmd, th);
31223128
return false;
31233129
}
31243130
}
3125-
3131+
31263132
private static Class<? extends TestBase> determineCommandClass(String cmd) {
31273133
CmdDescriptor descriptor = COMMANDS.get(cmd);
31283134
return descriptor != null ? descriptor.getCmdClass() : null;

0 commit comments

Comments
 (0)