HBASE-28643 An unbounded backup failure message can cause an irrecoverable state for the given backup (#6088)

rmdmattingly · Ray Mattingly · ndimiduk · commit 5aa73907bc67 · 2024-09-02T14:05:03.000+02:00
Co-authored-by: Ray Mattingly &lt;rmattingly@hubspot.com&gt;
Signed-off-by: Nick Dimiduk &lt;ndimiduk@apache.org&gt;
diff --git a/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java b/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java
@@ -44,6 +44,7 @@
 @InterfaceAudience.Private
 public class BackupInfo implements Comparable<BackupInfo> {
   private static final Logger LOG = LoggerFactory.getLogger(BackupInfo.class);
+  private static final int MAX_FAILED_MESSAGE_LENGTH = 1024;
 
   public interface Filter {
     /**
@@ -266,6 +267,9 @@ public String getFailedMsg() {
   }
 
   public void setFailedMsg(String failedMsg) {
+    if (failedMsg.length() > MAX_FAILED_MESSAGE_LENGTH) {
+      failedMsg = failedMsg.substring(0, MAX_FAILED_MESSAGE_LENGTH);
+    }
     this.failedMsg = failedMsg;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@`
`44`	`44`	`@InterfaceAudience.Private`
`45`	`45`	`public class BackupInfo implements Comparable<BackupInfo> {`
`46`	`46`	`private static final Logger LOG = LoggerFactory.getLogger(BackupInfo.class);`
	`47`	`+ private static final int MAX_FAILED_MESSAGE_LENGTH = 1024;`
`47`	`48`
`48`	`49`	`public interface Filter {`
`49`	`50`	`/**`
`@@ -266,6 +267,9 @@ public String getFailedMsg() {`
`266`	`267`	`}`
`267`	`268`
`268`	`269`	`public void setFailedMsg(String failedMsg) {`
	`270`	`+ if (failedMsg.length() > MAX_FAILED_MESSAGE_LENGTH) {`
	`271`	`+ failedMsg = failedMsg.substring(0, MAX_FAILED_MESSAGE_LENGTH);`
	`272`	`+ }`
`269`	`273`	`this.failedMsg = failedMsg;`
`270`	`274`	`}`
`271`	`275`