Skip to content

Commit 41621f0

Browse files
NihalJainNihalJain
authored
HBASE-28943 Remove all jackson 1.x dependencies for hadoop-3 profile, since all jackson 1.x versions have vulnerabilities (#6405)
- Building hbase with hadoop-3 profile on branch-2, still requires jackson 1.x jars, which has vulnerabilities. Ideally these should not be needed as with HADOOP-13332 hadoop has already "Remove jackson 1.9.13 and switch all jackson code to 2.x code line" for branch-3. - Also in HBASE-27148, where we worked on "Move minimum hadoop 3 support version to 3.2.3", where we had done a similar cleanup for branch-3; but somehow we missed to port the relevant changes to the branch-2 backport of same jira. This task is to take care of this so that we do not need jackson 1.x to build/run hbase with hadoop-3 profile on branch-2.x. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
1 parent b2c7bb2 commit 41621f0

File tree

4 files changed

+26
-76
lines changed
  • hbase-shaded

4 files changed

+26
-76
lines changed

‎hbase-shaded/hbase-shaded-client-byo-hadoop/pom.xml‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -140,38 +140,6 @@
140140
<artifactId>hadoop-common</artifactId>
141141
<scope>provided</scope>
142142
</dependency>
143-
<dependency>
144-
<groupId>org.codehaus.jackson</groupId>
145-
<artifactId>jackson-jaxrs</artifactId>
146-
<version>1.9.13</version>
147-
<scope>provided</scope>
148-
<exclusions>
149-
<exclusion>
150-
<groupId>org.codehaus.jackson</groupId>
151-
<artifactId>jackson-mapper-asl</artifactId>
152-
</exclusion>
153-
<exclusion>
154-
<groupId>org.codehaus.jackson</groupId>
155-
<artifactId>jackson-core-asl</artifactId>
156-
</exclusion>
157-
</exclusions>
158-
</dependency>
159-
<dependency>
160-
<groupId>org.codehaus.jackson</groupId>
161-
<artifactId>jackson-xc</artifactId>
162-
<version>1.9.13</version>
163-
<scope>provided</scope>
164-
<exclusions>
165-
<exclusion>
166-
<groupId>org.codehaus.jackson</groupId>
167-
<artifactId>jackson-mapper-asl</artifactId>
168-
</exclusion>
169-
<exclusion>
170-
<groupId>org.codehaus.jackson</groupId>
171-
<artifactId>jackson-core-asl</artifactId>
172-
</exclusion>
173-
</exclusions>
174-
</dependency>
175143
</dependencies>
176144
</profile>
177145
</profiles>

‎hbase-shaded/hbase-shaded-mapreduce/pom.xml‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -359,38 +359,6 @@
359359
</exclusion>
360360
</exclusions>
361361
</dependency>
362-
<dependency>
363-
<groupId>org.codehaus.jackson</groupId>
364-
<artifactId>jackson-jaxrs</artifactId>
365-
<version>1.9.13</version>
366-
<scope>provided</scope>
367-
<exclusions>
368-
<exclusion>
369-
<groupId>org.codehaus.jackson</groupId>
370-
<artifactId>jackson-mapper-asl</artifactId>
371-
</exclusion>
372-
<exclusion>
373-
<groupId>org.codehaus.jackson</groupId>
374-
<artifactId>jackson-core-asl</artifactId>
375-
</exclusion>
376-
</exclusions>
377-
</dependency>
378-
<dependency>
379-
<groupId>org.codehaus.jackson</groupId>
380-
<artifactId>jackson-xc</artifactId>
381-
<version>1.9.13</version>
382-
<scope>provided</scope>
383-
<exclusions>
384-
<exclusion>
385-
<groupId>org.codehaus.jackson</groupId>
386-
<artifactId>jackson-mapper-asl</artifactId>
387-
</exclusion>
388-
<exclusion>
389-
<groupId>org.codehaus.jackson</groupId>
390-
<artifactId>jackson-core-asl</artifactId>
391-
</exclusion>
392-
</exclusions>
393-
</dependency>
394362
</dependencies>
395363
</profile>
396364
</profiles>

‎hbase-shaded/hbase-shaded-testing-util-tester/pom.xml‎

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,26 @@
8383
<artifactId>hbase-shaded-testing-util</artifactId>
8484
<scope>test</scope>
8585
</dependency>
86-
<dependency>
87-
<groupId>org.codehaus.jackson</groupId>
88-
<artifactId>jackson-mapper-asl</artifactId>
89-
<version>1.9.13</version>
90-
<scope>test</scope>
91-
</dependency>
9286
</dependencies>
87+
<profiles>
88+
<profile>
89+
<id>hadoop-2.0</id>
90+
<activation>
91+
<property>
92+
<!--Below formatting for dev-support/generate-hadoopX-poms.sh-->
93+
<!--h2-->
94+
<name>!hadoop.profile</name>
95+
</property>
96+
</activation>
97+
<dependencies>
98+
<dependency>
99+
<groupId>org.codehaus.jackson</groupId>
100+
<artifactId>jackson-mapper-asl</artifactId>
101+
<version>1.9.13</version>
102+
<scope>test</scope>
103+
</dependency>
104+
</dependencies>
105+
</profile>
106+
</profiles>
93107

94108
</project>

‎hbase-shaded/hbase-shaded-testing-util/pom.xml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,6 @@
7474
<type>test-jar</type>
7575
<scope>compile</scope>
7676
</dependency>
77-
<dependency>
78-
<groupId>org.codehaus.jackson</groupId>
79-
<artifactId>jackson-jaxrs</artifactId>
80-
<version>1.9.13</version>
81-
<scope>compile</scope>
82-
</dependency>
8377
<dependency>
8478
<groupId>org.apache.hbase</groupId>
8579
<artifactId>hbase-testing-util</artifactId>
@@ -186,6 +180,12 @@
186180
<type>test-jar</type>
187181
<scope>compile</scope>
188182
</dependency>
183+
<dependency>
184+
<groupId>org.codehaus.jackson</groupId>
185+
<artifactId>jackson-jaxrs</artifactId>
186+
<version>1.9.13</version>
187+
<scope>compile</scope>
188+
</dependency>
189189
</dependencies>
190190
</profile>
191191
<!--

0 commit comments

Comments
 (0)