HBASE-26992 Brotli compressor has unexpected behavior during reinitialization (#4389)

apurtell · web-flow · commit 152ecad53a46 · 2022-04-30T09:11:33.000-07:00
Signed-off-by: Duo Zhang &lt;zhangduo@apache.org&gt;
diff --git a/hbase-compression/hbase-compression-brotli/src/main/java/org/apache/hadoop/hbase/io/compress/brotli/BrotliCompressor.java b/hbase-compression/hbase-compression-brotli/src/main/java/org/apache/hadoop/hbase/io/compress/brotli/BrotliCompressor.java
@@ -162,8 +162,8 @@ public void reinit(Configuration conf) {
       int newBufferSize = BrotliCodec.getBufferSize(conf);
       if (bufferSize != newBufferSize) {
         bufferSize = newBufferSize;
-        this.inBuf = ByteBuffer.allocateDirect(bufferSize);
-        this.outBuf = ByteBuffer.allocateDirect(bufferSize);
+        this.inBuf = ByteBuffer.allocate(bufferSize);
+        this.outBuf = ByteBuffer.allocate(bufferSize);
       }
     }
     reset();

Original file line number	Diff line number	Diff line change
`@@ -162,8 +162,8 @@ public void reinit(Configuration conf) {`
`162`	`162`	`int newBufferSize = BrotliCodec.getBufferSize(conf);`
`163`	`163`	`if (bufferSize != newBufferSize) {`
`164`	`164`	`bufferSize = newBufferSize;`
`165`		`- this.inBuf = ByteBuffer.allocateDirect(bufferSize);`
`166`		`- this.outBuf = ByteBuffer.allocateDirect(bufferSize);`
	`165`	`+ this.inBuf = ByteBuffer.allocate(bufferSize);`
	`166`	`+ this.outBuf = ByteBuffer.allocate(bufferSize);`
`167`	`167`	`}`
`168`	`168`	`}`
`169`	`169`	`reset();`