HBASE-21959 - CompactionTool should close the store it uses for compacting files, in order to properly archive compacted files.

wchevreuil · apurtell · commit 128adc0c3a08 · 2019-04-17T18:54:24.000-07:00
Reapply without unit test

Change-Id: If852529e79274a77eb08cac13936f02776232608
Signed-off-by: Xu Cang &lt;xucang@apache.org&gt;
Amending-Author: Andrew Purtell &lt;apurtell@apache.org&gt;
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java
@@ -171,6 +171,8 @@ private void compactStoreFiles(final Path tableDir, final HTableDescriptor htd,
           }
         }
       } while (store.needsCompaction() && !compactOnce);
+      //We need to close the store properly, to make sure it will archive compacted files
+      store.close();
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,8 @@ private void compactStoreFiles(final Path tableDir, final HTableDescriptor htd,`
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`	`} while (store.needsCompaction() && !compactOnce);`
	`174`	`+ //We need to close the store properly, to make sure it will archive compacted files`
	`175`	`+ store.close();`
`174`	`176`	`}`
`175`	`177`
`176`	`178`	`/**`