diff --git a/hadoop-project/pom.xml b/hadoop-project/pom.xml index a699daf09a206..4ad1c65e889af 100644 --- a/hadoop-project/pom.xml +++ b/hadoop-project/pom.xml @@ -2004,11 +2004,6 @@ snakeyaml ${snakeyaml.version} - - org.hamcrest - hamcrest-library - 1.3 - org.assertj assertj-core diff --git a/hadoop-tools/hadoop-aws/pom.xml b/hadoop-tools/hadoop-aws/pom.xml index e675c50f24170..3a0c0f53cf56f 100644 --- a/hadoop-tools/hadoop-aws/pom.xml +++ b/hadoop-tools/hadoop-aws/pom.xml @@ -573,11 +573,6 @@ hadoop-minikdc test - - org.hamcrest - hamcrest-library - test - org.bouncycastle diff --git a/hadoop-tools/hadoop-azure/pom.xml b/hadoop-tools/hadoop-azure/pom.xml index 58ac82736bd4b..5ce3a58441342 100644 --- a/hadoop-tools/hadoop-azure/pom.xml +++ b/hadoop-tools/hadoop-azure/pom.xml @@ -339,11 +339,6 @@ assertj-core test - - org.hamcrest - hamcrest-library - test - org.junit.jupiter junit-jupiter-api diff --git a/hadoop-tools/hadoop-distcp/pom.xml b/hadoop-tools/hadoop-distcp/pom.xml index 4c1b36d7662ee..a90713b1e102d 100644 --- a/hadoop-tools/hadoop-distcp/pom.xml +++ b/hadoop-tools/hadoop-distcp/pom.xml @@ -109,12 +109,6 @@ assertj-core test - - org.hamcrest - hamcrest-library - 1.3 - test - org.junit.jupiter junit-jupiter-api diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml index 7dbc8d1bc4cdb..d8fa7593021ad 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml @@ -81,6 +81,11 @@ junit-platform-launcher test + + org.assertj + assertj-core + test + org.apache.solr diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppDetailsControllerTest.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppDetailsControllerTest.java index 1ceab0a69a9aa..7c8a5883c0ebd 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppDetailsControllerTest.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppDetailsControllerTest.java @@ -22,6 +22,7 @@ import org.apache.hadoop.yarn.appcatalog.model.AppEntry; import org.apache.hadoop.yarn.service.api.records.Component; import org.apache.hadoop.yarn.service.api.records.Container; + import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.mockito.Mockito; @@ -29,8 +30,7 @@ import javax.ws.rs.Path; import javax.ws.rs.core.Response; -import static org.hamcrest.MatcherAssert.assertThat; -import static org.hamcrest.core.Is.is; +import static org.assertj.core.api.Assertions.assertThat; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.mockito.Mockito.when; @@ -126,14 +126,15 @@ void testRestartApp() throws Exception { void testPathAnnotation() throws Exception { assertNotNull(this.controller.getClass() .getAnnotations()); - assertThat("The controller has the annotation Path", - this.controller.getClass() - .isAnnotationPresent(Path.class)); - - final Path path = this.controller.getClass() - .getAnnotation(Path.class); - assertThat("The path is /app_details", path.value(), - is("/app_details")); + + assertThat(this.controller.getClass().isAnnotationPresent(Path.class)) + .as("The controller has the annotation Path") + .isTrue(); + + final Path path = this.controller.getClass().getAnnotation(Path.class); + assertThat(path.value()) + .as("The path is /app_details") + .isEqualTo("/app_details"); } @Test diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppListControllerTest.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppListControllerTest.java index d788de618a656..9991be389bfd0 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppListControllerTest.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppListControllerTest.java @@ -27,8 +27,7 @@ import javax.ws.rs.Path; import javax.ws.rs.core.Response; -import static org.hamcrest.MatcherAssert.assertThat; -import static org.hamcrest.core.Is.is; +import static org.assertj.core.api.Assertions.assertThat; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.mockito.Mockito.when; @@ -85,12 +84,15 @@ void testDeploy() throws Exception { void testPathAnnotation() throws Exception { assertNotNull(this.controller.getClass() .getAnnotations()); - assertThat("The controller has the annotation Path", - this.controller.getClass().isAnnotationPresent(Path.class)); - final Path path = this.controller.getClass() - .getAnnotation(Path.class); - assertThat("The path is /app_list", path.value(), is("/app_list")); + assertThat(this.controller.getClass().isAnnotationPresent(Path.class)) + .as("The controller has the annotation Path") + .isTrue(); + + final Path path = this.controller.getClass().getAnnotation(Path.class); + assertThat(path.value()) + .as("The path is /app_list") + .isEqualTo("/app_list"); } } diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppStoreControllerTest.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppStoreControllerTest.java index df0c6802b5a24..d8002f725d494 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppStoreControllerTest.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppStoreControllerTest.java @@ -27,8 +27,7 @@ import javax.ws.rs.Path; import javax.ws.rs.core.Response; -import static org.hamcrest.MatcherAssert.assertThat; -import static org.hamcrest.core.Is.is; +import static org.assertj.core.api.Assertions.assertThat; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.mockito.Mockito.when; @@ -86,13 +85,14 @@ void testRegister() throws Exception { void testPathAnnotation() throws Exception { assertNotNull(this.controller.getClass() .getAnnotations()); - assertThat("The controller has the annotation Path", - this.controller.getClass() - .isAnnotationPresent(Path.class)); - final Path path = this.controller.getClass() - .getAnnotation(Path.class); - assertThat("The path is /app_store", path.value(), is("/app_store")); - } + assertThat(this.controller.getClass().isAnnotationPresent(Path.class)) + .as("The controller has the annotation Path") + .isTrue(); + final Path path = this.controller.getClass().getAnnotation(Path.class); + assertThat(path.value()) + .as("The path is /app_store") + .isEqualTo("/app_store"); + } } diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java index 15ac9a54ea0ce..b940518bcfa3f 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java @@ -21,9 +21,7 @@ import org.apache.hadoop.conf.Configuration; -import static org.hamcrest.MatcherAssert.assertThat; -import static org.hamcrest.core.IsInstanceOf.instanceOf; -import static org.hamcrest.core.IsSame.sameInstance; +import static org.assertj.core.api.Assertions.assertThat; import static org.junit.jupiter.api.Assertions.assertNotNull; /** @@ -80,7 +78,7 @@ void testCreateInstance() { ResourceCalculatorProcessTree tree; tree = ResourceCalculatorProcessTree.getResourceCalculatorProcessTree("1", EmptyProcessTree.class, new Configuration()); assertNotNull(tree); - assertThat(tree, instanceOf(EmptyProcessTree.class)); + assertThat(tree).isInstanceOf(EmptyProcessTree.class); } @Test @@ -89,6 +87,6 @@ void testCreatedInstanceConfigured() { Configuration conf = new Configuration(); tree = ResourceCalculatorProcessTree.getResourceCalculatorProcessTree("1", EmptyProcessTree.class, conf); assertNotNull(tree); - assertThat(tree.getConf(), sameInstance(conf)); + assertThat(tree).isInstanceOf(EmptyProcessTree.class); } }