From 67c4a12587742642ae09762b5e1f55bac847340f Mon Sep 17 00:00:00 2001 From: Viraj Jasani Date: Thu, 9 Mar 2023 11:07:03 -0800 Subject: [PATCH 1/2] HDFS-16947. RBF NamenodeHeartbeatService to report error for not being able to register namenode in state store --- .../hdfs/server/federation/router/NamenodeHeartbeatService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java index 86e24a0b24acc..762c4f069a060 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java +++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java @@ -318,7 +318,7 @@ private void updateState() { LOG.warn("Cannot register namenode {}", report); } } catch (IOException e) { - LOG.info("Cannot register namenode in the State Store"); + LOG.error("Cannot register namenode in the State Store", e); } catch (Exception ex) { LOG.error("Unhandled exception updating NN registration for {}", getNamenodeDesc(), ex); From e08544b05136b30cfc7ee89307b56d3fb1a7004c Mon Sep 17 00:00:00 2001 From: Viraj Jasani Date: Fri, 10 Mar 2023 09:45:55 -0800 Subject: [PATCH 2/2] addendum --- .../server/federation/router/NamenodeHeartbeatService.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java index 762c4f069a060..9ffcea1a95c41 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java +++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java @@ -317,11 +317,8 @@ private void updateState() { if (!resolver.registerNamenode(report)) { LOG.warn("Cannot register namenode {}", report); } - } catch (IOException e) { - LOG.error("Cannot register namenode in the State Store", e); - } catch (Exception ex) { - LOG.error("Unhandled exception updating NN registration for {}", - getNamenodeDesc(), ex); + } catch (Exception e) { + LOG.error("Cannot register namenode {} in the State Store", getNamenodeDesc(), e); } }