From 5280a170ca4ad96f0e9e6ac4116c2e9817bcf1c3 Mon Sep 17 00:00:00 2001 From: Akira Ajisaka Date: Sun, 8 Aug 2021 14:10:50 +0900 Subject: [PATCH 1/3] HADOOP-17799. Improve the GitHub pull request template --- .github/pull_request_template.md | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2b5014b7b234d..d9eeb54c4e5b8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,18 @@ -## NOTICE + + +### Description of PR + + +### How was this patch tested? + + +### For code changes: + +- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? +- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? +- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? -Please create an issue in ASF JIRA before opening a pull request, -and you need to set the title of the pull request which starts with -the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.) -For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute From b83e609a92fc34e0f1ab0aab5f54ef1aeb1ba053 Mon Sep 17 00:00:00 2001 From: Akira Ajisaka Date: Sun, 8 Aug 2021 14:15:46 +0900 Subject: [PATCH 2/3] Update the example jira issue id --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d9eeb54c4e5b8..e4ab1c8f33336 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,7 +1,7 @@ ### Description of PR From 458ae01ae5a537bcfccd4bcd5a76ebb7040c2ec2 Mon Sep 17 00:00:00 2001 From: Akira Ajisaka Date: Tue, 10 Aug 2021 17:10:28 +0900 Subject: [PATCH 3/3] Add a checklist to make sure the PR title is in the specified format --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e4ab1c8f33336..2da45be7d6f98 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -12,6 +12,7 @@ ### For code changes: +- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?