YARN-11726: Adding test cases for IOException and change log from debug to info

Author: Hean Chhinling

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java

@@ -512,13 +512,18 @@ static String getPassword(Configuration conf, String alias) {
       char[] passchars = conf.getPassword(alias);
       if (passchars != null) {
         password = new String(passchars);
-        LOG.debug("Successful password retrieval for alias: {}", alias);
+        LOG.info("Successful password retrieval for alias: {}", alias);
       }
     }
     catch (IOException ioe) {
       password = null;
       LOG.error("Unable to retrieve password for alias: {}", alias, ioe);
     }
+
+    if (password == null) {
+      LOG.error("Password does not exist for alias: {}", alias);
+    }
+
     return password;
   }
 

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/util/TestWebAppUtils.java

@@ -25,6 +25,7 @@
 import java.util.Map;
 import javax.servlet.http.HttpServletRequest;
 
+import org.apache.hadoop.yarn.util.TestBoundedAppender;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
@@ -43,6 +44,7 @@
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.mockito.Mockito.when;
 
 public class TestWebAppUtils {
   private static final String RM1_NODE_ID = "rm1";
@@ -109,6 +111,15 @@ void testGetPassword() throws Exception {
     assertNull(WebAppUtils.getPassword(conf, "invalid-alias"));
   }
 
+  @Test
+  void testGetPasswordIOException() throws Exception {
+    Configuration mockConf = Mockito.mock(Configuration.class);
+
+    when(mockConf.getPassword("error-alias")).thenThrow(new IOException("Simulated IO error"));
+
+    assertNull(WebAppUtils.getPassword(mockConf, "error-alias"));
+  }
+
   @Test
   void testLoadSslConfiguration() throws Exception {
     Configuration conf = provisionCredentialsForSSL();
@@ -186,7 +197,7 @@ protected Configuration provisionCredentialsForSSL() throws IOException,
   void testAppendQueryParams() throws Exception {
     HttpServletRequest request = Mockito.mock(HttpServletRequest.class);
     String targetUri = "/test/path";
-    Mockito.when(request.getCharacterEncoding()).thenReturn(null);
+    when(request.getCharacterEncoding()).thenReturn(null);
     Map<String, String> paramResultMap = new HashMap<>();
     paramResultMap.put("param1=x", targetUri + "?" + "param1=x");
     paramResultMap
@@ -195,7 +206,7 @@ void testAppendQueryParams() throws Exception {
         targetUri + "?" + "param1=x&param2=y&param3=x+y");
 
     for (Map.Entry<String, String> entry : paramResultMap.entrySet()) {
-      Mockito.when(request.getQueryString()).thenReturn(entry.getKey());
+      when(request.getQueryString()).thenReturn(entry.getKey());
       String uri = WebAppUtils.appendQueryParams(request, targetUri);
       assertEquals(entry.getValue(), uri);
     }
@@ -205,8 +216,8 @@ void testAppendQueryParams() throws Exception {
   void testGetHtmlEscapedURIWithQueryString() throws Exception {
     HttpServletRequest request = Mockito.mock(HttpServletRequest.class);
     String targetUri = "/test/path";
-    Mockito.when(request.getCharacterEncoding()).thenReturn(null);
-    Mockito.when(request.getRequestURI()).thenReturn(targetUri);
+    when(request.getCharacterEncoding()).thenReturn(null);
+    when(request.getRequestURI()).thenReturn(targetUri);
     Map<String, String> paramResultMap = new HashMap<>();
     paramResultMap.put("param1=x", targetUri + "?" + "param1=x");
     paramResultMap
@@ -215,7 +226,7 @@ void testGetHtmlEscapedURIWithQueryString() throws Exception {
         targetUri + "?" + "param1=x&amp;param2=y&amp;param3=x+y");
 
     for (Map.Entry<String, String> entry : paramResultMap.entrySet()) {
-      Mockito.when(request.getQueryString()).thenReturn(entry.getKey());
+      when(request.getQueryString()).thenReturn(entry.getKey());
       String uri = WebAppUtils.getHtmlEscapedURIWithQueryString(request);
       assertEquals(entry.getValue(), uri);
     }