Skip to content

Commit 99c983e

Browse files
committed
Adding vectored io context info in S3aAInputStream.toString()
1 parent 0199bcb commit 99c983e

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -768,6 +768,7 @@ public String toString() {
768768
sb.append(" remainingInCurrentRequest=")
769769
.append(remainingInCurrentRequest());
770770
sb.append(" ").append(changeTracker);
771+
sb.append(" ").append(vectoredIOContext);
771772
sb.append('\n').append(s);
772773
sb.append('}');
773774
return sb.toString();

hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AReadOpContext.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@
2727

2828
import javax.annotation.Nullable;
2929

30-
import java.util.List;
31-
import java.util.function.IntFunction;
32-
3330
import org.apache.hadoop.util.Preconditions;
3431

3532
import static org.apache.hadoop.util.Preconditions.checkNotNull;

hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/VectoredIOContext.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,12 @@ public int getMinSeekForVectorReads() {
6767
public int getMaxReadSizeForVectorReads() {
6868
return maxReadSizeForVectorReads;
6969
}
70+
71+
@Override
72+
public String toString() {
73+
return "VectoredIOContext{" +
74+
"minSeekForVectorReads=" + minSeekForVectorReads +
75+
", maxReadSizeForVectorReads=" + maxReadSizeForVectorReads +
76+
'}';
77+
}
7078
}

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractVectoredRead.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ public void testMinSeekAndMaxSizeConfigsPropagation() throws Exception {
6969
conf.setInt(Constants.AWS_S3_MAX_READSIZE_VECTOR_READS, configuredMaxSize);
7070
try (S3AFileSystem fs = S3ATestUtils.createTestFileSystem(conf)) {
7171
try (FSDataInputStream fis = fs.open(path(VECTORED_READ_FILE_NAME))) {
72+
System.out.println(fis.toString());
7273
int newMinSeek = fis.minSeekForVectorReads();
7374
int newMaxSize = fis.maxReadSizeForVectorReads();
7475
assertEqual(newMinSeek, configuredMinSeek,

0 commit comments

Comments
 (0)