Skip to content

Commit 25af890

Browse files
committed
HDFS-15835. Erasure coding: Add/remove logs for the better readability/debugging. Contributed by Bhavik Patel.
1 parent 9a298d1 commit 25af890

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,7 @@ public synchronized ErasureCodingPolicy addPolicy(
343343
policiesByName.values().toArray(new ErasureCodingPolicyInfo[0]);
344344
allPersistedPolicies.put(policy.getId(),
345345
new ErasureCodingPolicyInfo(policy));
346+
LOG.info("Added erasure coding policy " + policy);
346347
return policy;
347348
}
348349

@@ -414,7 +415,7 @@ public synchronized boolean disablePolicy(String name) {
414415
enabledPolicies =
415416
enabledPoliciesByName.values().toArray(new ErasureCodingPolicy[0]);
416417
info.setState(ErasureCodingPolicyState.DISABLED);
417-
LOG.info("Disable the erasure coding policy " + name);
418+
LOG.info("Disabled the erasure coding policy " + name);
418419
allPersistedPolicies.put(info.getPolicy().getId(),
419420
createPolicyInfo(info.getPolicy(),
420421
ErasureCodingPolicyState.DISABLED));
@@ -448,7 +449,7 @@ public synchronized boolean enablePolicy(String name) {
448449
enabledPoliciesByName.values().toArray(new ErasureCodingPolicy[0]);
449450
allPersistedPolicies.put(ecPolicy.getId(),
450451
createPolicyInfo(info.getPolicy(), ErasureCodingPolicyState.ENABLED));
451-
LOG.info("Enable the erasure coding policy " + name);
452+
LOG.info("Enabled the erasure coding policy " + name);
452453
return true;
453454
}
454455

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8226,7 +8226,6 @@ boolean disableErasureCodingPolicy(String ecPolicyName,
82268226
checkOperation(OperationCategory.WRITE);
82278227
checkErasureCodingSupported(operationName);
82288228
boolean success = false;
8229-
LOG.info("Disable the erasure coding policy " + ecPolicyName);
82308229
try {
82318230
writeLock();
82328231
try {

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2258,10 +2258,10 @@ public void setErasureCodingPolicy(String src, String ecPolicyName)
22582258
try {
22592259
if (ecPolicyName == null) {
22602260
ecPolicyName = defaultECPolicyName;
2261-
LOG.trace("No policy name is specified, " +
2261+
LOG.debug("No policy name is specified, " +
22622262
"set the default policy name instead");
22632263
}
2264-
LOG.trace("Set erasure coding policy " + ecPolicyName + " on " + src);
2264+
LOG.debug("Set erasure coding policy {} on {}", ecPolicyName, src);
22652265
namesystem.setErasureCodingPolicy(src, ecPolicyName, cacheEntry != null);
22662266
success = true;
22672267
} finally {
@@ -2491,6 +2491,7 @@ public void unsetErasureCodingPolicy(String src) throws IOException {
24912491
}
24922492
boolean success = false;
24932493
try {
2494+
LOG.debug("Unset erasure coding policy on {}", src);
24942495
namesystem.unsetErasureCodingPolicy(src, cacheEntry != null);
24952496
success = true;
24962497
} finally {

0 commit comments

Comments
 (0)