Skip to content

don't delete lock file when lock is held by other #11324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbumenJ merged 1 commit into from
Jan 19, 2023
Merged

don't delete lock file when lock is held by other #11324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dubbo-common/src/main/java/org/apache/dubbo/common/cache/FileCacheStoreFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ private static FileCacheStore getFile(String name, boolean enableFileCache) {

private static void tryFileLock(FileCacheStore.Builder builder, String fileName) throws PathNotExclusiveException {
File lockFile = new File(fileName + ".lock");
lockFile.deleteOnExit();

FileLock dirLock;
try {
Expand All @@ -188,6 +187,7 @@ private static void tryFileLock(FileCacheStore.Builder builder, String fileName)
throw new PathNotExclusiveException(fileName + " is not exclusive. Maybe multiple Dubbo instances are using the same folder.");
}

lockFile.deleteOnExit();
builder.directoryLock(dirLock).lockFile(lockFile);
}

Expand Down