Skip to content

Commit 6616818

Browse files
committed
fix
1 parent 5f5959b commit 6616818

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/report/AbstractMetricsReporter.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,10 @@ private void addJvmMetrics() {
113113
Optional.ofNullable(applicationModel.getApplicationName()).orElse(""));
114114
new ClassLoaderMetrics(extraTags).bindTo(compositeRegistry);
115115
new JvmMemoryMetrics(extraTags).bindTo(compositeRegistry);
116+
117+
@SuppressWarnings("java:S2095")
118+
// Do not change JvmGcMetrics to try-with-resources as the JvmGcMetrics will not be available after (auto-)closing.
119+
// See https://github.com/micrometer-metrics/micrometer/issues/1492
116120
JvmGcMetrics jvmGcMetrics = new JvmGcMetrics(extraTags);
117121
jvmGcMetrics.bindTo(compositeRegistry);
118122
Runtime.getRuntime().addShutdownHook(new Thread(jvmGcMetrics::close));

0 commit comments

Comments
 (0)