From 5af0ede233790cecf795bd1abf89d52cf3049907 Mon Sep 17 00:00:00 2001 From: Jia-Xuan Liu Date: Sun, 10 Nov 2024 17:12:00 +0800 Subject: [PATCH 1/2] improve the testing coverage of bit_length --- .../test_files/string/dictionary_utf8.slt | 16 ++++++++++++++++ .../test_files/string/large_string.slt | 16 ++++++++++++++++ .../sqllogictest/test_files/string/string.slt | 16 ++++++++++++++++ .../test_files/string/string_view.slt | 9 +++++---- 4 files changed, 53 insertions(+), 4 deletions(-) diff --git a/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt b/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt index d0039f8dcd32b..8d89862855713 100644 --- a/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt +++ b/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt @@ -64,6 +64,22 @@ _ (empty) false false false false NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL +# TODO: move it back to `string_query.slt.part` after fixing the issue +# see issue https://github.com/apache/datafusion/pull/13221 +query IIII +select bit_length(ascii_1), bit_length(ascii_2), bit_length(unicode_1), bit_length(unicode_2) from test_basic_operator; +---- +48 8 144 32 +72 72 176 176 +56 8 240 64 +88 88 104 256 +56 24 216 288 +0 8 0 0 +8 16 0 0 +8 16 0 0 +NULL 8 NULL NULL +NULL 8 NULL 32 + # # common test for string-like functions and operators # diff --git a/datafusion/sqllogictest/test_files/string/large_string.slt b/datafusion/sqllogictest/test_files/string/large_string.slt index 5b738d0041e4d..ead9aac5018f2 100644 --- a/datafusion/sqllogictest/test_files/string/large_string.slt +++ b/datafusion/sqllogictest/test_files/string/large_string.slt @@ -71,6 +71,22 @@ _ (empty) false false false false NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL +# TODO: move it back to `string_query.slt.part` after fixing the issue +# see issue https://github.com/apache/datafusion/pull/13221 +query IIII +select bit_length(ascii_1), bit_length(ascii_2), bit_length(unicode_1), bit_length(unicode_2) from test_basic_operator; +---- +48 8 144 32 +72 72 176 176 +56 8 240 64 +88 88 104 256 +56 24 216 288 +0 8 0 0 +8 16 0 0 +8 16 0 0 +NULL 8 NULL NULL +NULL 8 NULL 32 + # # common test for string-like functions and operators # diff --git a/datafusion/sqllogictest/test_files/string/string.slt b/datafusion/sqllogictest/test_files/string/string.slt index 4e173de84f484..3b3ae589768f2 100644 --- a/datafusion/sqllogictest/test_files/string/string.slt +++ b/datafusion/sqllogictest/test_files/string/string.slt @@ -187,6 +187,22 @@ _ \_ (empty) (empty) true false false false percent p%t pan Tadeusz ma iść w kąt Pan Tadeusz ma frunąć stąd w kąt true false true true under_score un_____core un iść core chrząszcz na łące w 東京都 true false true false +# TODO: move it back to `string_query.slt.part` after fixing the issue +# see issue https://github.com/apache/datafusion/pull/13221 +query IIII +select bit_length(ascii_1), bit_length(ascii_2), bit_length(unicode_1), bit_length(unicode_2) from test_basic_operator; +---- +48 8 144 32 +72 72 176 176 +56 8 240 64 +88 88 104 256 +56 24 216 288 +0 8 0 0 +8 16 0 0 +8 16 0 0 +NULL 8 NULL NULL +NULL 8 NULL 32 + # # Clean up # diff --git a/datafusion/sqllogictest/test_files/string/string_view.slt b/datafusion/sqllogictest/test_files/string/string_view.slt index ce8a295373aa4..e76578ee0a9a3 100644 --- a/datafusion/sqllogictest/test_files/string/string_view.slt +++ b/datafusion/sqllogictest/test_files/string/string_view.slt @@ -37,6 +37,11 @@ select arrow_cast(col1, 'Utf8View') as c1 from test_substr_base; statement ok drop table test_source +# TODO: Revisit this issue after upgrading to the arrow-rs version that includes apache/arrow-rs#6671. +# see issue https://github.com/apache/datafusion/pull/13221 +query error DataFusion error: Arrow error: Compute error: bit_length not supported for Utf8View +select bit_length(ascii_1), bit_length(ascii_2), bit_length(unicode_1), bit_length(unicode_2) from test_basic_operator; + # # common test for string-like functions and operators # @@ -93,10 +98,6 @@ select octet_length(column1_utf8view) from test; 0 NULL -# TODO: Revisit this issue after upgrading to the arrow-rs version that includes apache/arrow-rs#6671. -query error DataFusion error: Arrow error: Compute error: bit_length not supported for Utf8View -select bit_length(column1_utf8view) from test; - query T select btrim(column1_large_utf8) from test; ---- From 96afea625e22852dcebde71b22487d725f77aa1e Mon Sep 17 00:00:00 2001 From: Jia-Xuan Liu Date: Wed, 13 Nov 2024 23:32:44 +0800 Subject: [PATCH 2/2] fix the issue links --- datafusion/sqllogictest/test_files/string/dictionary_utf8.slt | 2 +- datafusion/sqllogictest/test_files/string/large_string.slt | 2 +- datafusion/sqllogictest/test_files/string/string.slt | 2 +- datafusion/sqllogictest/test_files/string/string_view.slt | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt b/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt index 8d89862855713..c16cfc2ca38ea 100644 --- a/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt +++ b/datafusion/sqllogictest/test_files/string/dictionary_utf8.slt @@ -65,7 +65,7 @@ NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL # TODO: move it back to `string_query.slt.part` after fixing the issue -# see issue https://github.com/apache/datafusion/pull/13221 +# see issue https://github.com/apache/datafusion/issues/13329 query IIII select bit_length(ascii_1), bit_length(ascii_2), bit_length(unicode_1), bit_length(unicode_2) from test_basic_operator; ---- diff --git a/datafusion/sqllogictest/test_files/string/large_string.slt b/datafusion/sqllogictest/test_files/string/large_string.slt index ead9aac5018f2..35fc5694df6ff 100644 --- a/datafusion/sqllogictest/test_files/string/large_string.slt +++ b/datafusion/sqllogictest/test_files/string/large_string.slt @@ -72,7 +72,7 @@ NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL # TODO: move it back to `string_query.slt.part` after fixing the issue -# see issue https://github.com/apache/datafusion/pull/13221 +# see issue https://github.com/apache/datafusion/issues/13329 query IIII select bit_length(ascii_1), bit_length(ascii_2), bit_length(unicode_1), bit_length(unicode_2) from test_basic_operator; ---- diff --git a/datafusion/sqllogictest/test_files/string/string.slt b/datafusion/sqllogictest/test_files/string/string.slt index 3b3ae589768f2..db2b67d663336 100644 --- a/datafusion/sqllogictest/test_files/string/string.slt +++ b/datafusion/sqllogictest/test_files/string/string.slt @@ -188,7 +188,7 @@ percent p%t pan Tadeusz ma iść w kąt Pan Tadeusz ma frunąć stąd w kąt tru under_score un_____core un iść core chrząszcz na łące w 東京都 true false true false # TODO: move it back to `string_query.slt.part` after fixing the issue -# see issue https://github.com/apache/datafusion/pull/13221 +# see issue https://github.com/apache/datafusion/issues/13329 query IIII select bit_length(ascii_1), bit_length(ascii_2), bit_length(unicode_1), bit_length(unicode_2) from test_basic_operator; ---- diff --git a/datafusion/sqllogictest/test_files/string/string_view.slt b/datafusion/sqllogictest/test_files/string/string_view.slt index e76578ee0a9a3..7661b0a2b2721 100644 --- a/datafusion/sqllogictest/test_files/string/string_view.slt +++ b/datafusion/sqllogictest/test_files/string/string_view.slt @@ -38,7 +38,7 @@ statement ok drop table test_source # TODO: Revisit this issue after upgrading to the arrow-rs version that includes apache/arrow-rs#6671. -# see issue https://github.com/apache/datafusion/pull/13221 +# see issue https://github.com/apache/datafusion/issues/13329 query error DataFusion error: Arrow error: Compute error: bit_length not supported for Utf8View select bit_length(ascii_1), bit_length(ascii_2), bit_length(unicode_1), bit_length(unicode_2) from test_basic_operator;