Address PR comments

Author: watford-ep

src/dialect/mod.rs

@@ -1207,17 +1207,6 @@ pub trait Dialect: Debug + Any {
     fn supports_semantic_view_table_factor(&self) -> bool {
         false
     }
-
-    /// Returns true if the dialect supports the `RESET` statement
-    /// for resetting session variables.
-    ///
-    /// ```sql
-    /// RESET configuration_parameter;
-    /// RESET ALL;
-    /// ```
-    fn supports_reset(&self) -> bool {
-        false
-    }
 }
 
 /// This represents the operators for which precedence must be defined

src/dialect/postgresql.rs

@@ -280,11 +280,4 @@ impl Dialect for PostgreSqlDialect {
     fn supports_interval_options(&self) -> bool {
         true
     }
-
-    /// Postgres supports the `RESET` statement for resetting session variables.
-    ///
-    /// [PostgreSQL](https://www.postgresql.org/docs/current/sql-reset.html)
-    fn supports_reset(&self) -> bool {
-        true
-    }
 }

src/parser/mod.rs

@@ -656,7 +656,7 @@ impl<'a> Parser<'a> {
                     self.prev_token();
                     self.parse_vacuum()
                 }
-                Keyword::RESET if self.dialect.supports_reset() => self.parse_reset(),
+                Keyword::RESET => self.parse_reset(),
                 _ => self.expected("an SQL statement", next_token),
             },
             Token::LParen => {
@@ -17725,8 +17725,8 @@ impl<'a> Parser<'a> {
         }
     }
 
+    /// Parses a RESET statement
     fn parse_reset(&mut self) -> Result<Statement, ParserError> {
-        // RESET { ALL | <configuration_parameter> }
         if self.parse_keyword(Keyword::ALL) {
             return Ok(Statement::Reset(ResetStatement { reset: Reset::ALL }));
         }
@@ -18542,29 +18542,4 @@ mod tests {
             assert!(Parser::parse_sql(&GenericDialect, &sql).is_err());
         }
     }
-
-    #[test]
-    fn test_reset_all() {
-        let sql = "RESET ALL";
-        let ast = Parser::parse_sql(&PostgreSqlDialect {}, sql).unwrap();
-        assert_eq!(
-            ast,
-            vec![Statement::Reset(ResetStatement { reset: Reset::ALL })]
-        );
-    }
-
-    #[test]
-    fn test_reset_parameter() {
-        for w in ["parameter_name", "extension.parameter_name"] {
-            let sql = format!("RESET {w}");
-            let parts = w.split(".").map(|s| s.into()).collect::<Vec<Ident>>();
-            let ast = Parser::parse_sql(&PostgreSqlDialect {}, &sql).unwrap();
-            assert_eq!(
-                ast,
-                vec![Statement::Reset(ResetStatement {
-                    reset: Reset::ConfigurationParameter(ObjectName::from(parts))
-                })]
-            );
-        }
-    }
 }

tests/sqlparser_common.rs

@@ -17613,3 +17613,30 @@ fn test_parse_alter_user() {
     }
     verified_stmt("ALTER USER u1 SET DEFAULT_SECONDARY_ROLES=('ALL'), PASSWORD='secret', WORKLOAD_IDENTITY=(TYPE=AWS, ARN='arn:aws:iam::123456789:r1/')");
 }
+
+#[test]
+fn parse_reset_statement() {
+    match verified_stmt("RESET some_parameter") {
+        Statement::Reset(ResetStatement { reset }) => match reset {
+            Reset::ConfigurationParameter(o) => {
+                assert_eq!(o, ObjectName::from(vec!["some_parameter".into()]))
+            }
+            _ => unreachable!(),
+        },
+        _ => unreachable!(),
+    }
+    match verified_stmt("RESET some_extension.some_parameter") {
+        Statement::Reset(ResetStatement { reset }) => match reset {
+            Reset::ConfigurationParameter(o) => assert_eq!(
+                o,
+                ObjectName::from(vec!["some_extension".into(), "some_parameter".into()])
+            ),
+            _ => unreachable!(),
+        },
+        _ => unreachable!(),
+    }
+    match verified_stmt("RESET ALL") {
+        Statement::Reset(ResetStatement { reset }) => assert_eq!(reset, Reset::ALL),
+        _ => unreachable!(),
+    }
+}

tests/sqlparser_postgres.rs

@@ -6652,30 +6652,3 @@ fn parse_foreign_key_match_with_actions() {
 
     pg_and_generic().verified_stmt(sql);
 }
-
-#[test]
-fn parse_reset_statement() {
-    match pg().verified_stmt("RESET some_parameter") {
-        Statement::Reset(ResetStatement { reset }) => match reset {
-            Reset::ConfigurationParameter(o) => {
-                assert_eq!(o, ObjectName::from(vec!["some_parameter".into()]))
-            }
-            _ => unreachable!(),
-        },
-        _ => unreachable!(),
-    }
-    match pg().verified_stmt("RESET some_extension.some_parameter") {
-        Statement::Reset(ResetStatement { reset }) => match reset {
-            Reset::ConfigurationParameter(o) => assert_eq!(
-                o,
-                ObjectName::from(vec!["some_extension".into(), "some_parameter".into()])
-            ),
-            _ => unreachable!(),
-        },
-        _ => unreachable!(),
-    }
-    match pg().verified_stmt("RESET ALL") {
-        Statement::Reset(ResetStatement { reset }) => assert_eq!(reset, Reset::ALL),
-        _ => unreachable!(),
-    }
-}