Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Dec 6, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

Fixing more legacy tech debt.

What changes are included in this PR?

  • CometExecRule now delegates to CometBroadcastExchangeExec serde logic
  • Fallback reasons are now reported for operators that have BroadcastExchangeExec children (such as BroadcastHashJoinExec)
  • Removed CometExecRule.operator2Proto since it is no longer referenced
  • Updated golden files now that fallback reasons are being reported

How are these changes tested?

@andygrove andygrove changed the title Refactor CometExecRule handling of BroadcastHashJoin and show fallback reasons chore: Refactor CometExecRule handling of BroadcastHashJoin and show fallback reasons Dec 6, 2025
@andygrove andygrove marked this pull request as ready for review December 6, 2025 00:15
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.29%. Comparing base (f09f8af) to head (b7be893).
⚠️ Report is 741 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2856      +/-   ##
============================================
+ Coverage     56.12%   59.29%   +3.16%     
- Complexity      976     1350     +374     
============================================
  Files           119      167      +48     
  Lines         11743    15280    +3537     
  Branches       2251     2530     +279     
============================================
+ Hits           6591     9060    +2469     
- Misses         4012     4933     +921     
- Partials       1140     1287     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove changed the title chore: Refactor CometExecRule handling of BroadcastHashJoin and show fallback reasons chore: Refactor CometExecRule handling of BroadcastHashJoin and fix fallback reporting Dec 8, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove good catch

@andygrove
Copy link
Member Author

Thanks for the review @comphead. I'll go ahead and merge because I have some more changes to make that follow on from this one.

@andygrove andygrove merged commit ecaa4ae into apache:main Dec 8, 2025
115 checks passed
@andygrove andygrove deleted the refactor-comet-exec-broadcast branch December 8, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants