Skip to content

Commit bd5a0c7

Browse files
committed
Change default native memory management method to greedy_task_shared
1 parent 7f68c4f commit bd5a0c7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

common/src/main/scala/org/apache/comet/CometConf.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,9 +436,9 @@ object CometConf extends ShimCometConf {
436436
"The type of memory pool to be used for Comet native execution. " +
437437
"Available memory pool types are 'greedy', 'fair_spill', 'greedy_task_shared', " +
438438
"'fair_spill_task_shared', 'greedy_global' and 'fair_spill_global', By default, " +
439-
"this config is 'greedy'.")
439+
"this config is 'greedy_task_shared'.")
440440
.stringConf
441-
.createWithDefault("greedy")
441+
.createWithDefault("greedy_task_shared")
442442

443443
val COMET_PARQUET_ENABLE_DIRECT_BUFFER: ConfigEntry[Boolean] = conf(
444444
"spark.comet.parquet.enable.directBuffer")

docs/source/user-guide/configs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Comet provides the following configuration settings.
4949
| spark.comet.exec.hashJoin.enabled | Whether to enable hashJoin by default. | true |
5050
| spark.comet.exec.localLimit.enabled | Whether to enable localLimit by default. | true |
5151
| spark.comet.exec.memoryFraction | The fraction of memory from Comet memory overhead that the native memory manager can use for execution. The purpose of this config is to set aside memory for untracked data structures, as well as imprecise size estimation during memory acquisition. Default value is 0.7. | 0.7 |
52-
| spark.comet.exec.memoryPool | The type of memory pool to be used for Comet native execution. Available memory pool types are 'greedy', 'fair_spill', 'greedy_task_shared', 'fair_spill_task_shared', 'greedy_global' and 'fair_spill_global', By default, this config is 'greedy'. | greedy |
52+
| spark.comet.exec.memoryPool | The type of memory pool to be used for Comet native execution. Available memory pool types are 'greedy', 'fair_spill', 'greedy_task_shared', 'fair_spill_task_shared', 'greedy_global' and 'fair_spill_global', By default, this config is 'greedy_task_shared'. | greedy_task_shared |
5353
| spark.comet.exec.project.enabled | Whether to enable project by default. | true |
5454
| spark.comet.exec.shuffle.codec | The codec of Comet native shuffle used to compress shuffle data. Only zstd is supported. | zstd |
5555
| spark.comet.exec.shuffle.enabled | Whether to enable Comet native shuffle. Note that this requires setting 'spark.shuffle.manager' to 'org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager'. 'spark.shuffle.manager' must be set before starting the Spark application and cannot be changed during the application. | true |

0 commit comments

Comments
 (0)