[TEXT-239] TextStringBuilder.append(char[], int, int) uses wrong

variable in exception message #735

Use longer lines
Keep test methods in AB order

Author: garydgregory

src/changes/changes.xml

@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
     <release version="1.15.1" date="YYYY-MM-DD" description="This is a feature and maintenance release. Java 8 or later is required.">
       <!-- FIX -->
       <action type="fix" dev="ggregory" due-to="Dominik Stadler, Gary Gregory">Improve test coverage #732.</action>
+      <action type="fix" dev="ggregory" issue="TEXT-239" due-to="Dominik Stadler, Gary Gregory">TextStringBuilder.append(char[], int, int) uses wrong variable in exception message #735.</action>
       <!-- ADD -->
       <!-- UPDATE -->
       <action type="update" dev="ggregory" due-to="Gary Gregory">Bump org.apache.commons:commons-parent from 93 to 96.</action>

src/test/java/org/apache/commons/text/StrBuilderTest.java

@@ -834,6 +834,16 @@ void testEqualsIgnoreCase() {
         assertTrue(sb1.equalsIgnoreCase(sb2));
     }
 
+    @Test
+    void testErrorMessageShowsCorrectVariable() {
+        final StrBuilder sb = new StrBuilder("Hello");
+        final char[] chars = { 'a', 'b', 'c' };
+        StringIndexOutOfBoundsException ex = assertThrows(StringIndexOutOfBoundsException.class, () -> sb.append(chars, 1, 4));
+        assertTrue(ex.getMessage().contains("length: 4"));
+        ex = assertThrows(StringIndexOutOfBoundsException.class, () -> sb.append(chars, 7, 3));
+        assertTrue(ex.getMessage().contains("startIndex: 7"));
+    }
+
     @Test
     void testGetChars() {
         final StrBuilder sb = new StrBuilder();
@@ -2016,22 +2026,4 @@ void testTrim() {
         sb.clear().append("a b c");
         assertEquals("a b c", sb.trim().toString());
     }
-
-    @Test
-    void testErrorMessageShowsCorrectVariable() {
-        final StrBuilder sb = new StrBuilder("Hello");
-        final char[] chars = {'a', 'b', 'c'};
-
-        StringIndexOutOfBoundsException ex = assertThrows(
-                StringIndexOutOfBoundsException.class,
-                () -> sb.append(chars, 1, 4)
-        );
-        assertTrue(ex.getMessage().contains("length: 4"));
-
-        ex = assertThrows(
-                StringIndexOutOfBoundsException.class,
-                () -> sb.append(chars, 7, 3)
-        );
-        assertTrue(ex.getMessage().contains("startIndex: 7"));
-    }
 }

src/test/java/org/apache/commons/text/TextStringBuilderTest.java

@@ -989,6 +989,16 @@ void testEqualsIgnoreCase() {
         // TextStringBuilder("title".toUpperCase(turkish))));
     }
 
+    @Test
+    void testErrorMessageShowsCorrectVariable() {
+        final TextStringBuilder sb = new TextStringBuilder("Hello");
+        final char[] chars = { 'a', 'b', 'c' };
+        StringIndexOutOfBoundsException ex = assertThrows(StringIndexOutOfBoundsException.class, () -> sb.append(chars, 1, 4));
+        assertTrue(ex.getMessage().contains("length: 4"));
+        ex = assertThrows(StringIndexOutOfBoundsException.class, () -> sb.append(chars, 7, 3));
+        assertTrue(ex.getMessage().contains("startIndex: 7"));
+    }
+
     @Test
     void testGetChars() {
         final TextStringBuilder sb = new TextStringBuilder();
@@ -2392,22 +2402,4 @@ void testWrap_CharArray_Int_Exceptions() {
         assertThrows(IllegalArgumentException.class, () -> TextStringBuilder.wrap("abc".toCharArray(), -1));
         assertThrows(IllegalArgumentException.class, () -> TextStringBuilder.wrap(ArrayUtils.EMPTY_CHAR_ARRAY, 1));
     }
-
-    @Test
-    void testErrorMessageShowsCorrectVariable() {
-        final TextStringBuilder sb = new TextStringBuilder("Hello");
-        final char[] chars = {'a', 'b', 'c'};
-
-        StringIndexOutOfBoundsException ex = assertThrows(
-                StringIndexOutOfBoundsException.class,
-                () -> sb.append(chars, 1, 4)
-        );
-        assertTrue(ex.getMessage().contains("length: 4"));
-
-        ex = assertThrows(
-                StringIndexOutOfBoundsException.class,
-                () -> sb.append(chars, 7, 3)
-        );
-        assertTrue(ex.getMessage().contains("startIndex: 7"));
-    }
 }