Skip to content

[Improve] Repeated defer ledger lock release. #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hanmz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Improve] Repeated defer ledger lock release. #4666

hanmz wants to merge 1 commit into from
+2 −0

Conversation

@hanmz
Copy link
Contributor

@hanmz hanmz commented Sep 24, 2025 •
edited
Loading

Motivation

Method underreplicationManager.releaseUnderreplicatedLedger(ledgerIdToReplicate) has call in method logBKExceptionAndReleaseLedger(e, ledgerIdToReplicate), so we not need execute underreplicationManager.releaseUnderreplicatedLedger(ledgerIdToReplicate) in finally.

Changes

Set deferLedgerLockRelease is true after execute logBKExceptionAndReleaseLedger(e, ledgerIdToReplicate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hanmz