Skip to content

Commit fe07fe7

Browse files
authored
Fix test expectations which appear to fail with differences in generated proto classes (#36680)
* Fix test expectations which appear to fail with differences in proto generation * fix spotless
1 parent 2761883 commit fe07fe7

File tree

1 file changed

+14
-29
lines changed

1 file changed

+14
-29
lines changed

sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/ProcessBundleHandlerTest.java

Lines changed: 14 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,10 @@
2121
import static org.apache.beam.fn.harness.control.ProcessBundleHandler.REGISTERED_RUNNER_FACTORIES;
2222
import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkState;
2323
import static org.hamcrest.MatcherAssert.assertThat;
24-
import static org.hamcrest.Matchers.allOf;
2524
import static org.hamcrest.Matchers.contains;
2625
import static org.hamcrest.Matchers.containsInAnyOrder;
2726
import static org.hamcrest.Matchers.emptyIterable;
2827
import static org.hamcrest.Matchers.equalTo;
29-
import static org.hamcrest.Matchers.hasEntry;
30-
import static org.hamcrest.Matchers.hasProperty;
3128
import static org.hamcrest.Matchers.is;
3229
import static org.hamcrest.collection.IsEmptyCollection.empty;
3330
import static org.junit.Assert.assertEquals;
@@ -1998,19 +1995,13 @@ public void testTimerMetrics() throws Exception {
19981995
for (MetricsApi.MonitoringInfo info : response.getProcessBundle().getMonitoringInfosList()) {
19991996
if (info.getLabelsOrDefault("NAME", "").equals("timersFired")) {
20001997
++timerCounterFound;
2001-
assertThat(
2002-
info,
2003-
allOf(
2004-
hasProperty("urn", equalTo("beam:metric:user:sum_int64:v1")),
2005-
hasProperty("type", equalTo("beam:metrics:sum_int64:v1")),
2006-
hasProperty("payload", equalTo(ByteString.copyFromUtf8("\001"))),
2007-
hasProperty(
2008-
"labels",
2009-
hasEntry(
2010-
equalTo("NAMESPACE"),
2011-
equalTo(
2012-
"org.apache.beam.fn.harness.control.ProcessBundleHandlerTest$SimpleDoFn"))),
2013-
hasProperty("labels", hasEntry(equalTo("PTRANSFORM"), equalTo("3L")))));
1998+
assertEquals("beam:metric:user:sum_int64:v1", info.getUrn());
1999+
assertEquals("beam:metrics:sum_int64:v1", info.getType());
2000+
assertEquals(
2001+
"org.apache.beam.fn.harness.control.ProcessBundleHandlerTest$SimpleDoFn",
2002+
info.getLabelsOrDefault("NAMESPACE", ""));
2003+
assertEquals("3L", info.getLabelsOrDefault("PTRANSFORM", ""));
2004+
assertEquals(ByteString.copyFromUtf8("\001"), info.getPayload());
20142005
}
20152006
}
20162007
assertEquals(1, timerCounterFound);
@@ -2057,19 +2048,13 @@ public void testStartFinishBundleMetrics() throws Exception {
20572048
} else {
20582049
continue;
20592050
}
2060-
assertThat(
2061-
info,
2062-
allOf(
2063-
hasProperty("urn", equalTo("beam:metric:user:sum_int64:v1")),
2064-
hasProperty("type", equalTo("beam:metrics:sum_int64:v1")),
2065-
hasProperty("payload", equalTo(ByteString.copyFromUtf8("\001"))),
2066-
hasProperty(
2067-
"labels",
2068-
hasEntry(
2069-
equalTo("NAMESPACE"),
2070-
equalTo(
2071-
"org.apache.beam.fn.harness.control.ProcessBundleHandlerTest$SimpleDoFn"))),
2072-
hasProperty("labels", hasEntry(equalTo("PTRANSFORM"), equalTo("3L")))));
2051+
assertEquals("beam:metric:user:sum_int64:v1", info.getUrn());
2052+
assertEquals("beam:metrics:sum_int64:v1", info.getType());
2053+
assertEquals(
2054+
"org.apache.beam.fn.harness.control.ProcessBundleHandlerTest$SimpleDoFn",
2055+
info.getLabelsOrDefault("NAMESPACE", ""));
2056+
assertEquals("3L", info.getLabelsOrDefault("PTRANSFORM", ""));
2057+
assertEquals(ByteString.copyFromUtf8("\001"), info.getPayload());
20732058
}
20742059
assertEquals(1, startCounterFound);
20752060
assertEquals(1, finishCounterFound);

0 commit comments

Comments
 (0)