AVRO-3631: Add support for ser_de Value::Fixed

It is based on serde-rs/bytes#28 which is not
yet merged.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

Author: martin-g

lang/rust/avro/src/de.rs

@@ -329,7 +329,7 @@ impl<'a, 'de> de::Deserializer<'de> for &'a Deserializer<'de> {
             Value::String(ref s) => visitor.visit_bytes(s.as_bytes()),
             Value::Bytes(ref bytes) | Value::Fixed(_, ref bytes) => visitor.visit_bytes(bytes),
             Value::Uuid(ref u) => visitor.visit_bytes(u.as_bytes()),
-            _ => Err(de::Error::custom("not a string|bytes|fixed")),
+            _ => Err(de::Error::custom("not a string|bytes|fixed|uuid")),
         }
     }
 
@@ -600,6 +600,7 @@ pub fn from_value<'de, D: Deserialize<'de>>(value: &'de Value) -> Result<D, Erro
 mod tests {
     use pretty_assertions::assert_eq;
     use serde::Serialize;
+    use serde_bytes::ByteArray;
     use uuid::Uuid;
 
     use super::*;
@@ -1127,16 +1128,16 @@ mod tests {
     }
 
     #[test]
-    fn test_struct_fixed_field_avro_3631() {
+    fn avro_3631_test_struct_fixed_field() {
         #[derive(Debug, Serialize, Deserialize)]
         struct TestStructFixedField {
-            field: [u8; 6],
+            field: ByteArray<6>,
         }
 
         let value = Value::Record(vec![(
             "field".to_string(),
             Value::Fixed(6, vec![0, 0, 0, 0, 0, 0]),
         )]);
-        let _deserialized: TestStructFixedField = crate::from_value(&value).unwrap();
+        let _deserialized: TestStructFixedField = from_value(&value).unwrap();
     }
 }

lang/rust/avro/src/ser.rs

@@ -174,7 +174,7 @@ impl<'b> ser::Serializer for &'b mut Serializer {
     }
 
     fn serialize_bytes(self, v: &[u8]) -> Result<Self::Ok, Self::Error> {
-        Ok(Value::Bytes(v.to_owned()))
+        Ok(Value::Fixed(v.len(), v.to_owned()))
     }
 
     fn serialize_none(self) -> Result<Self::Ok, Self::Error> {
@@ -487,6 +487,7 @@ mod tests {
     use super::*;
     use pretty_assertions::assert_eq;
     use serde::{Deserialize, Serialize};
+    use serde_bytes::ByteArray;
 
     #[derive(Debug, Deserialize, Serialize, Clone)]
     struct Test {
@@ -679,7 +680,7 @@ mod tests {
 
     #[derive(Debug, Serialize, Deserialize)]
     struct TestStructFixedField {
-        field: [u8; 6],
+        field: ByteArray<6>,
     }
 
     #[test]
@@ -1005,15 +1006,17 @@ mod tests {
     }
 
     #[test]
-    fn test_to_value_fixed_field_avro_3631() {
-        let test = TestStructFixedField { field: [1; 6] };
+    fn avro_3631_test_to_value_fixed_field() {
+        let test = TestStructFixedField {
+            field: ByteArray::new([1; 6]),
+        };
         let expected = Value::Record(vec![(
             "field".to_owned(),
-            Value::Fixed(6, Vec::from(test.field.clone())),
+            Value::Fixed(6, Vec::from(test.field.clone().into_array())),
         )]);
         assert_eq!(
-            to_value(test).unwrap(),
             expected,
+            to_value(test).unwrap(),
             "error serializing fixed array"
         );
     }

lang/rust/avro/src/types.rs

@@ -1013,6 +1013,7 @@ mod tests {
     use apache_avro_test_helper::logger::{assert_logged, assert_not_logged};
     use pretty_assertions::assert_eq;
     use serde::{Deserialize, Serialize};
+    use serde_bytes::ByteArray;
     use uuid::Uuid;
 
     #[test]
@@ -2634,14 +2635,16 @@ Field with name '"b"' is not a member of the map items"#,
         avro_3688_schema_resolution_panic(true);
     }
 
-    #[derive(Debug, Serialize, Deserialize)]
-    struct TestStructFixedField {
-        field: [u8; 6],
-    }
-
     #[test]
-    fn test_avro_3631_serialize_fixed_fields() {
-        let test = TestStructFixedField { field: [1; 6] };
+    fn avro_3631_test_serialize_fixed_fields() {
+        #[derive(Debug, Serialize, Deserialize)]
+        struct TestStructFixedField {
+            field: ByteArray<6>,
+        }
+
+        let test = TestStructFixedField {
+            field: ByteArray::new([1; 6]),
+        };
         let value: Value = to_value(test).unwrap();
         let schema = Schema::parse_str(
             r#"