From a328069b709751f25e56dce5fc502662c17a9913 Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Thu, 2 Apr 2026 23:21:27 +0100 Subject: [PATCH 1/5] Check for non-API calls --- dev/tasks/r/github.linux.cran.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dev/tasks/r/github.linux.cran.yml b/dev/tasks/r/github.linux.cran.yml index 0bad0e2b66e..73c048f53e8 100644 --- a/dev/tasks/r/github.linux.cran.yml +++ b/dev/tasks/r/github.linux.cran.yml @@ -55,6 +55,13 @@ jobs: - name: Dump test logs run: cat arrow/r/check/arrow.Rcheck/tests/testthat.Rout* if: always() + - name: Check for non-API calls + run: | + if grep -q "non-API" arrow/r/check/arrow.Rcheck/00check.log; then + echo "Found non-API calls in R CMD check output:" + grep -A2 "non-API" arrow/r/check/arrow.Rcheck/00check.log + exit 1 + fi - name: Save the test output if: always() uses: actions/upload-artifact@v4 From dd88443a20af3fbafffb5c956f73945501e05b4b Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Fri, 3 Apr 2026 00:08:21 +0100 Subject: [PATCH 2/5] Grab all NOTEs --- dev/tasks/r/github.linux.cran.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dev/tasks/r/github.linux.cran.yml b/dev/tasks/r/github.linux.cran.yml index 73c048f53e8..ba2de492548 100644 --- a/dev/tasks/r/github.linux.cran.yml +++ b/dev/tasks/r/github.linux.cran.yml @@ -48,18 +48,18 @@ jobs: env: {{ macros.github_set_sccache_envvars()|indent(8)}} # setting ARROW_SOURCE_HOME='' here ensures that we use the cpp source copied into tools/ - run: archery docker run -e ARROW_SOURCE_HOME='' -e SKIP_VIGNETTES={{ '${{ matrix.config.skip_vignettes }}' }} r + run: archery docker run -e ARROW_SOURCE_HOME='' -e SKIP_VIGNETTES={{ '${{ matrix.config.skip_vignettes }}' }} -e _R_CHECK_CRAN_INCOMING_=false r - name: Dump install logs run: cat arrow/r/check/arrow.Rcheck/00install.out if: always() - name: Dump test logs run: cat arrow/r/check/arrow.Rcheck/tests/testthat.Rout* if: always() - - name: Check for non-API calls + - name: Check for R CMD check NOTES run: | - if grep -q "non-API" arrow/r/check/arrow.Rcheck/00check.log; then - echo "Found non-API calls in R CMD check output:" - grep -A2 "non-API" arrow/r/check/arrow.Rcheck/00check.log + if grep -q "^.* checking .* \\.\\.\\. NOTE$" arrow/r/check/arrow.Rcheck/00check.log; then + echo "Found R CMD check NOTE(s) in output:" + grep -n "^.* checking .* \\.\\.\\. NOTE$" arrow/r/check/arrow.Rcheck/00check.log exit 1 fi - name: Save the test output From 65bb5c3096e26ebb55852533234f8648643ae733 Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Fri, 3 Apr 2026 00:41:39 +0100 Subject: [PATCH 3/5] Show more lines --- dev/tasks/r/github.linux.cran.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/tasks/r/github.linux.cran.yml b/dev/tasks/r/github.linux.cran.yml index ba2de492548..2b6582eada8 100644 --- a/dev/tasks/r/github.linux.cran.yml +++ b/dev/tasks/r/github.linux.cran.yml @@ -59,7 +59,7 @@ jobs: run: | if grep -q "^.* checking .* \\.\\.\\. NOTE$" arrow/r/check/arrow.Rcheck/00check.log; then echo "Found R CMD check NOTE(s) in output:" - grep -n "^.* checking .* \\.\\.\\. NOTE$" arrow/r/check/arrow.Rcheck/00check.log + grep -n -A8 "^.* checking .* \\.\\.\\. NOTE$" arrow/r/check/arrow.Rcheck/00check.log exit 1 fi - name: Save the test output From 9e62f7609fd7f81f22faf3655069f91e4fc58cc0 Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Sat, 4 Apr 2026 22:15:57 +0100 Subject: [PATCH 4/5] exclude known flags --- dev/tasks/r/github.linux.cran.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/dev/tasks/r/github.linux.cran.yml b/dev/tasks/r/github.linux.cran.yml index 2b6582eada8..60cd08cffd7 100644 --- a/dev/tasks/r/github.linux.cran.yml +++ b/dev/tasks/r/github.linux.cran.yml @@ -48,7 +48,13 @@ jobs: env: {{ macros.github_set_sccache_envvars()|indent(8)}} # setting ARROW_SOURCE_HOME='' here ensures that we use the cpp source copied into tools/ - run: archery docker run -e ARROW_SOURCE_HOME='' -e SKIP_VIGNETTES={{ '${{ matrix.config.skip_vignettes }}' }} -e _R_CHECK_CRAN_INCOMING_=false r + run: > + archery docker run + -e ARROW_SOURCE_HOME='' + -e SKIP_VIGNETTES={{ '${{ matrix.config.skip_vignettes }}' }} + -e _R_CHECK_CRAN_INCOMING_=false + -e _R_CHECK_COMPILATION_FLAGS_KNOWN_="-Werror=implicit-function-declaration -Wno-error=enum-constexpr-conversion -Wp,-D_FORTIFY_SOURCE=3 -Wno-missing-template-arg-list-after-template-kw" + r - name: Dump install logs run: cat arrow/r/check/arrow.Rcheck/00install.out if: always() From f830d50c8a218001c20447fa19876904fc2dc8fd Mon Sep 17 00:00:00 2001 From: Jonathan Keane Date: Sun, 5 Apr 2026 20:58:07 -0500 Subject: [PATCH 5/5] Update dev/tasks/r/github.linux.cran.yml --- dev/tasks/r/github.linux.cran.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/dev/tasks/r/github.linux.cran.yml b/dev/tasks/r/github.linux.cran.yml index 60cd08cffd7..a136e1a6be9 100644 --- a/dev/tasks/r/github.linux.cran.yml +++ b/dev/tasks/r/github.linux.cran.yml @@ -53,7 +53,6 @@ jobs: -e ARROW_SOURCE_HOME='' -e SKIP_VIGNETTES={{ '${{ matrix.config.skip_vignettes }}' }} -e _R_CHECK_CRAN_INCOMING_=false - -e _R_CHECK_COMPILATION_FLAGS_KNOWN_="-Werror=implicit-function-declaration -Wno-error=enum-constexpr-conversion -Wp,-D_FORTIFY_SOURCE=3 -Wno-missing-template-arg-list-after-template-kw" r - name: Dump install logs run: cat arrow/r/check/arrow.Rcheck/00install.out