Fix new clippy lints from Rust 1.89 (#8078)

# Which issue does this PR close?


# Rationale for this change

Clippy is failing on main. Here is an example
-
https://github.com/apache/arrow-rs/actions/runs/16804746850/job/47594208868

Rust 1.89 was released today and it includes a new clippy version that
is more strict about some lints:
https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/



# What changes are included in this PR?

Fix clippy lints to make CI pass with Rust 1.89



# Are these changes tested?

By CI

# Are there any user-facing changes?

Author: alamb

arrow-array/src/ffi.rs

@@ -525,7 +525,7 @@ impl ImportedArrowArray<'_> {
         unsafe { create_buffer(self.owner.clone(), self.array, 0, buffer_len) }
     }
 
-    fn dictionary(&self) -> Result<Option<ImportedArrowArray>> {
+    fn dictionary(&self) -> Result<Option<ImportedArrowArray<'_>>> {
         match (self.array.dictionary(), &self.data_type) {
             (Some(array), DataType::Dictionary(_, value_type)) => Ok(Some(ImportedArrowArray {
                 array,

arrow-buffer/src/buffer/boolean.rs

@@ -104,7 +104,7 @@ impl BooleanBuffer {
     /// Returns a `BitChunks` instance which can be used to iterate over
     /// this buffer's bits in `u64` chunks
     #[inline]
-    pub fn bit_chunks(&self) -> BitChunks {
+    pub fn bit_chunks(&self) -> BitChunks<'_> {
         BitChunks::new(self.values(), self.offset, self.len)
     }
 

arrow-buffer/src/buffer/immutable.rs

@@ -350,7 +350,7 @@ impl Buffer {
     /// Returns a `BitChunks` instance which can be used to iterate over this buffers bits
     /// in larger chunks and starting at arbitrary bit offsets.
     /// Note that both `offset` and `length` are measured in bits.
-    pub fn bit_chunks(&self, offset: usize, len: usize) -> BitChunks {
+    pub fn bit_chunks(&self, offset: usize, len: usize) -> BitChunks<'_> {
         BitChunks::new(self.as_slice(), offset, len)
     }
 

arrow-cast/src/pretty.rs

@@ -1240,9 +1240,10 @@ mod tests {
         // Pretty formatting
         let opts = FormatOptions::default().with_null("null");
         let opts = opts.with_duration_format(DurationFormat::Pretty);
-        let pretty = pretty_format_columns_with_options("pretty", &[array.clone()], &opts)
-            .unwrap()
-            .to_string();
+        let pretty =
+            pretty_format_columns_with_options("pretty", std::slice::from_ref(&array), &opts)
+                .unwrap()
+                .to_string();
 
         // Expected output
         let expected_pretty = vec![

arrow-data/src/transform/boolean.rs

@@ -19,7 +19,7 @@ use super::{Extend, _MutableArrayData, utils::resize_for_bits};
 use crate::bit_mask::set_bits;
 use crate::ArrayData;
 
-pub(super) fn build_extend(array: &ArrayData) -> Extend {
+pub(super) fn build_extend(array: &ArrayData) -> Extend<'_> {
     let values = array.buffers()[0].as_slice();
     Box::new(
         move |mutable: &mut _MutableArrayData, _, start: usize, len: usize| {

arrow-data/src/transform/fixed_binary.rs

@@ -19,7 +19,7 @@ use super::{Extend, _MutableArrayData};
 use crate::ArrayData;
 use arrow_schema::DataType;
 
-pub(super) fn build_extend(array: &ArrayData) -> Extend {
+pub(super) fn build_extend(array: &ArrayData) -> Extend<'_> {
     let size = match array.data_type() {
         DataType::FixedSizeBinary(i) => *i as usize,
         _ => unreachable!(),

arrow-data/src/transform/fixed_size_list.rs

@@ -20,7 +20,7 @@ use arrow_schema::DataType;
 
 use super::{Extend, _MutableArrayData};
 
-pub(super) fn build_extend(array: &ArrayData) -> Extend {
+pub(super) fn build_extend(array: &ArrayData) -> Extend<'_> {
     let size = match array.data_type() {
         DataType::FixedSizeList(_, i) => *i as usize,
         _ => unreachable!(),

arrow-data/src/transform/list.rs

@@ -23,7 +23,9 @@ use crate::ArrayData;
 use arrow_buffer::ArrowNativeType;
 use num::{CheckedAdd, Integer};
 
-pub(super) fn build_extend<T: ArrowNativeType + Integer + CheckedAdd>(array: &ArrayData) -> Extend {
+pub(super) fn build_extend<T: ArrowNativeType + Integer + CheckedAdd>(
+    array: &ArrayData,
+) -> Extend<'_> {
     let offsets = array.buffer::<T>(0);
     Box::new(
         move |mutable: &mut _MutableArrayData, index: usize, start: usize, len: usize| {

arrow-data/src/transform/mod.rs

@@ -73,7 +73,7 @@ impl _MutableArrayData<'_> {
     }
 }
 
-fn build_extend_null_bits(array: &ArrayData, use_nulls: bool) -> ExtendNullBits {
+fn build_extend_null_bits(array: &ArrayData, use_nulls: bool) -> ExtendNullBits<'_> {
     if let Some(nulls) = array.nulls() {
         let bytes = nulls.validity();
         Box::new(move |mutable, start, len| {
@@ -190,7 +190,7 @@ impl std::fmt::Debug for MutableArrayData<'_> {
 /// Builds an extend that adds `offset` to the source primitive
 /// Additionally validates that `max` fits into the
 /// the underlying primitive returning None if not
-fn build_extend_dictionary(array: &ArrayData, offset: usize, max: usize) -> Option<Extend> {
+fn build_extend_dictionary(array: &ArrayData, offset: usize, max: usize) -> Option<Extend<'_>> {
     macro_rules! validate_and_build {
         ($dt: ty) => {{
             let _: $dt = max.try_into().ok()?;
@@ -215,7 +215,7 @@ fn build_extend_dictionary(array: &ArrayData, offset: usize, max: usize) -> Opti
 }
 
 /// Builds an extend that adds `buffer_offset` to any buffer indices encountered
-fn build_extend_view(array: &ArrayData, buffer_offset: u32) -> Extend {
+fn build_extend_view(array: &ArrayData, buffer_offset: u32) -> Extend<'_> {
     let views = array.buffer::<u128>(0);
     Box::new(
         move |mutable: &mut _MutableArrayData, _, start: usize, len: usize| {
@@ -234,7 +234,7 @@ fn build_extend_view(array: &ArrayData, buffer_offset: u32) -> Extend {
     )
 }
 
-fn build_extend(array: &ArrayData) -> Extend {
+fn build_extend(array: &ArrayData) -> Extend<'_> {
     match array.data_type() {
         DataType::Null => null::build_extend(array),
         DataType::Boolean => boolean::build_extend(array),

arrow-data/src/transform/null.rs

@@ -18,7 +18,7 @@
 use super::{Extend, _MutableArrayData};
 use crate::ArrayData;
 
-pub(super) fn build_extend(_: &ArrayData) -> Extend {
+pub(super) fn build_extend(_: &ArrayData) -> Extend<'_> {
     Box::new(move |_, _, _, _| {})
 }