Commit d379b98
authored
[Parquet] Minor: Update comments in page decompressor (#8764)
# Which issue does this PR close?
- follow on to #8756
# Rationale for this change
@etseidl comments:
#8756 (comment)
> Not relevant to this PR, but I think this TODO has largely been
addressed by #8376 which enabled
skipping the decoding of the page statistics.
While I was in here, I also wanted to capture the learning based on
@mapleFU 's comment
#8756 (comment)
> The code looks good to me but the I don't know if the comment "not
compressed" can be replaced, if decompress_buffer is called and
decompressed_size == 0 , seems that it generally means something like
"this page only have levels, but not have non-null values"? ( Point me
out if I'm wrong)
# What changes are included in this PR?
Include some comments
# Are these changes tested?
No (there are no code changes)
# Are there any user-facing changes?
No, this is internal comments only. No code / behavior changes1 parent 220d0ea commit d379b98
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
387 | 387 | | |
388 | 388 | | |
389 | 389 | | |
390 | | - | |
391 | | - | |
392 | 390 | | |
393 | 391 | | |
394 | 392 | | |
| |||
398 | 396 | | |
399 | 397 | | |
400 | 398 | | |
| 399 | + | |
| 400 | + | |
401 | 401 | | |
402 | 402 | | |
403 | 403 | | |
| |||
0 commit comments