Handle nested projection with derived column optimization #8951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafasrepo
previously approved these changes
Jan 23, 2024
Contributor
mustafasrepo
left a comment
mustafasrepo
left a comment
There was a problem hiding this comment.
LGTM!. Thanks for this fix
Contributor
|
@gruuya after some thinking through, I think best approach is your initial suggestion in the issue. I think, the only safe condition we can remove top projection is schema having same, and all expressions are trivial. And window test changes are another issue, that this fix reveals. And we should fix them separately. I filed the PR8960 with I think safest way to proceed is that PR. What do you think? |
mustafasrepo
dismissed
their stale review
after some thinking through, we can proceed with a safer approach
Contributor
Author
Agreed, that makes sense; closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8942.
Rationale for this change
Before discarding an outer projection that has the same output schema as the optimized inner projection, check for the equality of their expressions as well, and if these are different (e.g. having a non-trivial but aliased expression) keep the outer node.
What changes are included in this PR?
Changes to the
OptimizeProjectionslogical optimizer.Are these changes tested?
Yes, a test is added.
Are there any user-facing changes?
Fixes a regression from #8942.